ppcdisasm: Cleanup spr calculation.

joevt · dingusdev · commit 356e74f8c2b9 · 2026-01-29T07:53:17.000-07:00
diff --git a/cpu/ppc/ppcdisasm.cpp b/cpu/ppc/ppcdisasm.cpp
@@ -1394,9 +1394,9 @@ void opc_group31(PPCDisasmContext* ctx) {
         break;
     }
 
-    auto ref_spr  = (((ctx->instr_code >> 11) & 31) << 5) | ((ctx->instr_code >> 16) & 31);
     auto spr_high = (ctx->instr_code >> 11) & 31;
     auto spr_low  = (ctx->instr_code >> 16) & 31;
+    auto ref_spr  = (spr_high << 5) | spr_low;
 
     switch (ext_opc) {
     case 0: /* cmp */

Original file line number	Diff line number	Diff line change
`@@ -1394,9 +1394,9 @@ void opc_group31(PPCDisasmContext* ctx) {`
`1394`	`1394`	`break;`
`1395`	`1395`	`}`
`1396`	`1396`
`1397`		`- auto ref_spr = (((ctx->instr_code >> 11) & 31) << 5) \| ((ctx->instr_code >> 16) & 31);`
`1398`	`1397`	`auto spr_high = (ctx->instr_code >> 11) & 31;`
`1399`	`1398`	`auto spr_low = (ctx->instr_code >> 16) & 31;`
	`1399`	`+ auto ref_spr = (spr_high << 5) \| spr_low;`
`1400`	`1400`
`1401`	`1401`	`switch (ext_opc) {`
`1402`	`1402`	`case 0: /* cmp */`