From 81d2c5c0c90b787819139723d8f8661a31ccaa51 Mon Sep 17 00:00:00 2001 From: Alan Guo Xiang Tan Date: Wed, 23 Apr 2025 10:20:04 +0800 Subject: [PATCH] DEV: Add `ci-stable` job This plugin is important so we want to ensure that the tests pass against the `stable` branch too. --- .github/workflows/discourse-plugin.yml | 5 +++++ spec/system/core_features_spec.rb | 12 +++++------- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/.github/workflows/discourse-plugin.yml b/.github/workflows/discourse-plugin.yml index f5cf62e5..bf35664c 100644 --- a/.github/workflows/discourse-plugin.yml +++ b/.github/workflows/discourse-plugin.yml @@ -9,3 +9,8 @@ on: jobs: ci: uses: discourse/.github/.github/workflows/discourse-plugin.yml@v1 + + ci-stable: + uses: discourse/.github/.github/workflows/discourse-plugin.yml@v1 + with: + core_ref: stable diff --git a/spec/system/core_features_spec.rb b/spec/system/core_features_spec.rb index 9eb3b146..9683305f 100644 --- a/spec/system/core_features_spec.rb +++ b/spec/system/core_features_spec.rb @@ -1,10 +1,8 @@ # frozen_string_literal: true -RSpec.describe "Core features", type: :system do - # TODO: Stop skipping when shared example is available in stable - next if Discourse.git_branch == "stable" +# TODO: Stop skipping when shared example is available in stable +# RSpec.describe "Core features", type: :system do +# before { enable_current_plugin } - before { enable_current_plugin } - - it_behaves_like "having working core features" -end +# it_behaves_like "having working core features" +# end