Skip to content

Commit 63fe6bc

Browse files
authored
perf: remove deprecated modules (#47)
* perf: replace deprecated module * refactor: remove provideRouter
1 parent 2dbffbe commit 63fe6bc

3 files changed

Lines changed: 6 additions & 8 deletions

File tree

src/app/home/course/course.page.spec.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,17 @@ import { CoursePage } from './course.page';
33
import { AngularFireAuth } from '@angular/fire/compat/auth';
44
import { ActivatedRouteStub, FireAnalyticsStub, FireAuthStub } from '../../stubs';
55
import { ManService, ManServiceStub } from '../../man.service';
6-
import { RouterTestingModule } from '@angular/router/testing';
76
import { AngularFireAnalytics } from '@angular/fire/compat/analytics';
87
import { ActivatedRoute } from '@angular/router';
9-
import { IonicModule } from '@ionic/angular/ionic-module';
8+
import { IonicModule } from '@ionic/angular';
109

1110
describe('CoursePage', () => {
1211
let component: CoursePage;
1312
let fixture: ComponentFixture<CoursePage>;
1413

1514
beforeEach(waitForAsync(() => {
1615
TestBed.configureTestingModule({
17-
imports: [IonicModule.forRoot(), RouterTestingModule, CoursePage],
16+
imports: [IonicModule.forRoot(), CoursePage],
1817
providers: [
1918
{ provide: ActivatedRoute, useValue: ActivatedRouteStub },
2019
{ provide: AngularFireAnalytics, useValue: FireAnalyticsStub },

src/app/home/home.page.spec.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,15 @@ import { HomePage } from './home.page';
33
import { AngularFireAuth } from '@angular/fire/compat/auth';
44
import { FireAuthStub } from '../stubs';
55
import { ManService, ManServiceStub } from '../man.service';
6-
import { RouterTestingModule } from '@angular/router/testing';
7-
import { IonicModule } from '@ionic/angular/ionic-module';
6+
import { IonicModule } from '@ionic/angular';
87

98
describe('HomePage', () => {
109
let component: HomePage;
1110
let fixture: ComponentFixture<HomePage>;
1211

1312
beforeEach(waitForAsync(() => {
1413
TestBed.configureTestingModule({
15-
imports: [IonicModule.forRoot(), RouterTestingModule, HomePage],
14+
imports: [IonicModule.forRoot(), HomePage],
1615
providers: [
1716
{ provide: AngularFireAuth, useValue: FireAuthStub },
1817
{ provide: ManService, useValue: ManServiceStub }

src/app/home/list/list.page.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
22
import { ListPage } from './list.page';
3-
import { RouterTestingModule } from '@angular/router/testing';
43
import { ActivatedRoute } from '@angular/router';
54
import { ActivatedRouteStub } from '../../stubs';
65
import { ManService, ManServiceStub } from '../../man.service';
6+
import { IonicModule } from '@ionic/angular';
77

88
describe('ListPage', () => {
99
let component: ListPage;
1010
let fixture: ComponentFixture<ListPage>;
1111

1212
beforeEach(waitForAsync(() => {
1313
TestBed.configureTestingModule({
14-
imports: [IonicModule.forRoot(), RouterTestingModule, ListPage],
14+
imports: [IonicModule.forRoot(), ListPage],
1515
providers: [
1616
{ provide: ActivatedRoute, useValue: ActivatedRouteStub },
1717
{ provide: ManService, useValue: ManServiceStub }

0 commit comments

Comments
 (0)