BUG: Adds httpsPort as a valid serviceDest

thomasjpfan · thomasjpfan · commit 98108bf3a59d · 2018-06-14T21:19:35.000-04:00
diff --git a/proxy/types.go b/proxy/types.go
@@ -510,7 +510,8 @@ func isServiceDestValid(provider ServiceParameterProvider, index int) bool {
 	hasPath := len(provider.GetString(fmt.Sprintf("servicePath%s", suffix))) > 0
 	hasPort := len(provider.GetString(fmt.Sprintf("port%s", suffix))) > 0
 	hasDomain := len(provider.GetString(fmt.Sprintf("serviceDomain%s", suffix))) > 0
-	return hasPath || hasPort || hasDomain
+	hasHttpsPort := len(provider.GetString(fmt.Sprintf("httpsPort%s", suffix))) > 0
+	return hasPath || hasPort || hasDomain || hasHttpsPort
 }
 
 func getBoolParam(req ServiceParameterProvider, param, index string) bool {

Original file line number	Diff line number	Diff line change
`@@ -510,7 +510,8 @@ func isServiceDestValid(provider ServiceParameterProvider, index int) bool {`
`510`	`510`	`hasPath := len(provider.GetString(fmt.Sprintf("servicePath%s", suffix))) > 0`
`511`	`511`	`hasPort := len(provider.GetString(fmt.Sprintf("port%s", suffix))) > 0`
`512`	`512`	`hasDomain := len(provider.GetString(fmt.Sprintf("serviceDomain%s", suffix))) > 0`
`513`		`- return hasPath \|\| hasPort \|\| hasDomain`
	`513`	`+ hasHttpsPort := len(provider.GetString(fmt.Sprintf("httpsPort%s", suffix))) > 0`
	`514`	`+ return hasPath \|\| hasPort \|\| hasDomain \|\| hasHttpsPort`
`514`	`515`	`}`
`515`	`516`
`516`	`517`	`func getBoolParam(req ServiceParameterProvider, param, index string) bool {`