Merge pull request #805 from rumpl/nicer-skip

rumpl · web-flow · commit 0cf3be6d0f55 · 2025-11-15T00:56:06.000+01:00
Make it more clear what and why is flaky
diff --git a/e2e/cagent_exec_test.go b/e2e/cagent_exec_test.go
@@ -19,7 +19,7 @@ func TestExec_OpenAI(t *testing.T) {
 }
 
 func TestExec_OpenAI_ToolCall(t *testing.T) {
-	t.Skip("flaky because of tool call ordering")
+	t.Skip("flaky because of tool call arguments ordering, see #797")
 
 	out := cagentExec(t, "testdata/fs_tools.yaml", "How many files in testdata/working_dir? Only output the number.")
 
@@ -39,7 +39,7 @@ func TestExec_Anthropic(t *testing.T) {
 }
 
 func TestExec_Anthropic_ToolCall(t *testing.T) {
-	t.Skip("flaky because of tool call ordering")
+	t.Skip("flaky because of tool call arguments ordering, see #797")
 
 	out := cagentExec(t, "testdata/fs_tools.yaml", "--model=anthropic/claude-sonnet-4-0", "How many files in testdata/working_dir? Only output the number.")
 
@@ -53,7 +53,7 @@ func TestExec_Gemini(t *testing.T) {
 }
 
 func TestExec_Gemini_ToolCall(t *testing.T) {
-	t.Skip("flaky because of tool call ordering")
+	t.Skip("flaky because of tool call arguments ordering, see #797")
 
 	out := cagentExec(t, "testdata/fs_tools.yaml", "--model=google/gemini-2.5-flash", "How many files in testdata/working_dir? Only output the number.")
 

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ func TestExec_OpenAI(t *testing.T) {`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`func TestExec_OpenAI_ToolCall(t *testing.T) {`
`22`		`- t.Skip("flaky because of tool call ordering")`
	`22`	`+ t.Skip("flaky because of tool call arguments ordering, see #797")`
`23`	`23`
`24`	`24`	`out := cagentExec(t, "testdata/fs_tools.yaml", "How many files in testdata/working_dir? Only output the number.")`
`25`	`25`
`@@ -39,7 +39,7 @@ func TestExec_Anthropic(t *testing.T) {`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`func TestExec_Anthropic_ToolCall(t *testing.T) {`
`42`		`- t.Skip("flaky because of tool call ordering")`
	`42`	`+ t.Skip("flaky because of tool call arguments ordering, see #797")`
`43`	`43`
`44`	`44`	`out := cagentExec(t, "testdata/fs_tools.yaml", "--model=anthropic/claude-sonnet-4-0", "How many files in testdata/working_dir? Only output the number.")`
`45`	`45`
`@@ -53,7 +53,7 @@ func TestExec_Gemini(t *testing.T) {`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`func TestExec_Gemini_ToolCall(t *testing.T) {`
`56`		`- t.Skip("flaky because of tool call ordering")`
	`56`	`+ t.Skip("flaky because of tool call arguments ordering, see #797")`
`57`	`57`
`58`	`58`	`out := cagentExec(t, "testdata/fs_tools.yaml", "--model=google/gemini-2.5-flash", "How many files in testdata/working_dir? Only output the number.")`
`59`	`59`