Actually copy RuntimeConfig

Signed-off-by: David Gageot <david.gageot@docker.com>

Author: dgageot

e2e/proxy_test.go

@@ -75,7 +75,9 @@ func startRecordingAIProxy(t *testing.T) (*httptest.Server, *config.RuntimeConfi
 	t.Cleanup(httpServer.Close)
 
 	return httpServer, &config.RuntimeConfig{
-		ModelsGateway: httpServer.URL,
+		Config: config.Config{
+			ModelsGateway: httpServer.URL,
+		},
 		EnvProviderForTests: &testEnvProvider{
 			environment.DockerDesktopTokenEnv: "DUMMY",
 		},

pkg/config/runtime.go

@@ -8,14 +8,24 @@ import (
 )
 
 type RuntimeConfig struct {
+	Config
+
 	EnvProviderForTests environment.Provider
-	EnvFiles            []string
-	ModelsGateway       string
-	GlobalCodeMode      bool
-	WorkingDir          string
+	envProvider         environment.Provider
+	envProviderLock     sync.Mutex
+}
 
-	envProvider     environment.Provider
-	envProviderLock sync.Mutex
+type Config struct {
+	EnvFiles       []string
+	ModelsGateway  string
+	GlobalCodeMode bool
+	WorkingDir     string
+}
+
+func (runConfig *RuntimeConfig) Clone() *RuntimeConfig {
+	return &RuntimeConfig{
+		Config: runConfig.Config,
+	}
 }
 
 func (runConfig *RuntimeConfig) EnvProvider() environment.Provider {

pkg/config/runtime_test.go

@@ -0,0 +1,25 @@
+package config
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestClone_ChangeWorkingDir(t *testing.T) {
+	original := &RuntimeConfig{
+		Config: Config{
+			EnvFiles:       []string{"file1.env", "file2.env"},
+			ModelsGateway:  "http://models.gateway",
+			GlobalCodeMode: true,
+			WorkingDir:     "/app",
+		},
+	}
+
+	clone := original.Clone()
+	original.WorkingDir = "/newapp"
+	clone.WorkingDir = "/cloneapp"
+
+	assert.Equal(t, "/newapp", original.WorkingDir)
+	assert.Equal(t, "/cloneapp", clone.WorkingDir)
+}

pkg/server/server.go

@@ -1181,7 +1181,7 @@ func (s *Server) runAgent(c echo.Context) error {
 	p := addYamlExt(agentFilename)
 
 	// Copy runConfig and inject per-session working dir override
-	rc := s.runConfig
+	rc := s.runConfig.Clone()
 	rc.WorkingDir = sess.WorkingDir
 
 	// Load team - either reload from disk (local) or use in-memory team (OCI refs)