Merge pull request #1088 from vvoland/fix-shell

dgageot · web-flow · commit 3e9ccbedfb5e · 2025-12-13T17:36:50.000+01:00
tools/script_shell: Fix implicit all required parameters
diff --git a/pkg/tools/builtin/script_shell.go b/pkg/tools/builtin/script_shell.go
@@ -37,7 +37,7 @@ func NewScriptShellTool(shellTools map[string]latest.ScriptShellToolConfig, env
 func validateConfig(toolName string, tool latest.ScriptShellToolConfig) error {
 	// If no required array was set, all arguments are required
 	if tool.Required == nil {
-		tool.Required = make([]string, len(tool.Args))
+		tool.Required = make([]string, 0, len(tool.Args))
 		for argName := range tool.Args {
 			tool.Required = append(tool.Required, argName)
 		}

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ func NewScriptShellTool(shellTools map[string]latest.ScriptShellToolConfig, env`
`37`	`37`	`func validateConfig(toolName string, tool latest.ScriptShellToolConfig) error {`
`38`	`38`	`// If no required array was set, all arguments are required`
`39`	`39`	`if tool.Required == nil {`
`40`		`- tool.Required = make([]string, len(tool.Args))`
	`40`	`+ tool.Required = make([]string, 0, len(tool.Args))`
`41`	`41`	`for argName := range tool.Args {`
`42`	`42`	`tool.Required = append(tool.Required, argName)`
`43`	`43`	`}`