Improve save

Signed-off-by: David Gageot <david.gageot@docker.com>

Author: dgageot

pkg/evaluation/evaluation.go

@@ -3,7 +3,6 @@ package evaluation
 import (
 	"context"
 	"encoding/json"
-	"fmt"
 	"os"
 	"path/filepath"
 	"strings"
@@ -170,30 +169,3 @@ func toolTrajectoryScore(expectedToolMessages, actualToolMessages []session.Mess
 
 	return score / float64(len(expectedToolMessages))
 }
-
-func Save(sess *session.Session) (string, error) {
-	if err := os.MkdirAll("evals", 0o755); err != nil {
-		return "", err
-	}
-
-	fileName := sess.ID + ".json"
-	if _, err := os.Stat("evals/" + fileName); err == nil {
-		number := 1
-		for {
-			fileName = fmt.Sprintf("%s_%d.json", sess.ID, number)
-			if _, err := os.Stat("evals/" + fileName); err != nil {
-				break
-			}
-			number++
-		}
-	}
-
-	evalFile := filepath.Join("evals", fileName)
-	file, err := os.Create(evalFile)
-	if err != nil {
-		return "", err
-	}
-	defer file.Close()
-
-	return evalFile, json.NewEncoder(file).Encode(sess)
-}

pkg/evaluation/save.go

@@ -0,0 +1,33 @@
+package evaluation
+
+import (
+	"encoding/json"
+	"fmt"
+	"os"
+	"path/filepath"
+
+	"github.com/docker/cagent/pkg/session"
+)
+
+func Save(sess *session.Session) (string, error) {
+	if err := os.MkdirAll("evals", 0o755); err != nil {
+		return "", err
+	}
+
+	evalFile := filepath.Join("evals", fmt.Sprintf("%s.json", sess.ID))
+	for number := 1; ; number++ {
+		if _, err := os.Stat(evalFile); err != nil {
+			break
+		}
+
+		evalFile = filepath.Join("evals", fmt.Sprintf("%s_%d.json", sess.ID, number))
+	}
+
+	file, err := os.Create(evalFile)
+	if err != nil {
+		return "", err
+	}
+	defer file.Close()
+
+	return evalFile, json.NewEncoder(file).Encode(sess)
+}