Skip to content

Commit 51e91a2

Browse files
authored
Merge pull request #1488 from derekmisler/removed-unnecessary-thinking-and-force-agent-to-po
Removed unnecessary thinking and force agent to post a comment, even if no issues were found
2 parents 4cc5cbf + e202eff commit 51e91a2

2 files changed

Lines changed: 11 additions & 5 deletions

File tree

.github/workflows/agents/pr-review.yaml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,14 @@ agents:
2828
2929
Find **real bugs in the changed code**, not style issues. If the changed code works correctly, approve it.
3030
31+
## ALWAYS Post a Review
32+
33+
You MUST always post a review via the GitHub API, even if no issues were found.
34+
- If no issues: Post an APPROVE with a brief positive message (e.g., "Looks good! No issues found.")
35+
- If issues found: Post COMMENT or REQUEST_CHANGES with inline comments
36+
37+
Users find it confusing when no review comment is posted - they don't know if the review ran.
38+
3139
## Posting Reviews with Inline Comments
3240
3341
The drafter returns issues in this format:
@@ -69,7 +77,6 @@ agents:
6977
- type: shell
7078
- type: memory
7179
path: .github/pr-review-memory.db
72-
- type: think
7380

7481
drafter:
7582
model: sonnet
@@ -143,7 +150,7 @@ agents:
143150
toolsets:
144151
- type: filesystem
145152
tools: [read_file, read_multiple_files, list_directory, directory_tree]
146-
- type: think
153+
- type: think # Keep thinking for bug hypothesis generation
147154

148155
verifier:
149156
model: sonnet
@@ -181,7 +188,6 @@ agents:
181188
toolsets:
182189
- type: filesystem
183190
tools: [read_file, read_multiple_files, list_directory, directory_tree]
184-
- type: think
185191

186192
permissions:
187193
allow:

.github/workflows/pr-review.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
6363
- name: Process feedback and update memory
6464
if: steps.check.outputs.is_agent_comment == 'true'
65-
uses: docker/cagent-action@7992ea47ed2446b5a80b01c46b00037c680e35ea
65+
uses: docker/cagent-action@latest
6666
with:
6767
agent: ${{ github.workspace }}/.github/workflows/agents/pr-review-feedback.yaml
6868
prompt: |
@@ -192,7 +192,7 @@ jobs:
192192
echo "EOF" >> $GITHUB_OUTPUT
193193
194194
- name: Run PR Review Team
195-
uses: docker/cagent-action@7992ea47ed2446b5a80b01c46b00037c680e35ea
195+
uses: docker/cagent-action@latest
196196
with:
197197
agent: ${{ github.workspace }}/.github/workflows/agents/pr-review.yaml
198198
prompt: ${{ steps.read-context.outputs.prompt }}

0 commit comments

Comments
 (0)