Merge pull request #1579 from dgageot/fix-metric

dgageot · web-flow · commit 8c5b1e5960a6 · 2026-02-03T16:25:44.000+01:00
Fix cagent eval metric
diff --git a/pkg/evaluation/scoring.go b/pkg/evaluation/scoring.go
@@ -128,10 +128,10 @@ func printMetric(out io.Writer, label string, passed, total int) {
 }
 
 func printMetricFloat(out io.Writer, label string, passed, total float64) {
-	ratio := 0.0
-	if total > 0 {
-		ratio = passed / total
+	if total == 0 {
+		return // Skip metrics with no data
 	}
+	ratio := passed / total
 	fmt.Fprintf(out, "%s %14s: %.0f/%.0f passed (%.1f%%)\n", statusIcon(ratio), label, passed, total, ratio*100)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -128,10 +128,10 @@ func printMetric(out io.Writer, label string, passed, total int) {`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`func printMetricFloat(out io.Writer, label string, passed, total float64) {`
`131`		`- ratio := 0.0`
`132`		`- if total > 0 {`
`133`		`- ratio = passed / total`
	`131`	`+ if total == 0 {`
	`132`	`+ return // Skip metrics with no data`
`134`	`133`	`}`
	`134`	`+ ratio := passed / total`
`135`	`135`	`fmt.Fprintf(out, "%s %14s: %.0f/%.0f passed (%.1f%%)\n", statusIcon(ratio), label, passed, total, ratio*100)`
`136`	`136`	`}`
`137`	`137`