Skip to content

Commit 9fd67fa

Browse files
committed
Doesn't fail
Signed-off-by: David Gageot <david.gageot@docker.com>
1 parent 7542ce6 commit 9fd67fa

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

pkg/teamloader/teamloader.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ func createTool(ctx context.Context, toolset latest.Toolset, parentDir string, e
346346

347347
// TODO(dga): until the MCP Gateway supports oauth with cagent, we fetch the remote url and directly connect to it.
348348
if serverSpec.Type == "remote" {
349-
return mcp.NewRemoteToolset(serverSpec.Remote.URL, serverSpec.Remote.TransportType, nil, runtimeConfig.RedirectURI)
349+
return mcp.NewRemoteToolset(serverSpec.Remote.URL, serverSpec.Remote.TransportType, nil, runtimeConfig.RedirectURI), nil
350350
}
351351

352352
return mcp.NewGatewayToolset(mcpServerName, toolset.Config, envProvider), nil
@@ -365,7 +365,7 @@ func createTool(ctx context.Context, toolset latest.Toolset, parentDir string, e
365365
headers[k] = expanded
366366
}
367367

368-
return mcp.NewRemoteToolset(toolset.Remote.URL, toolset.Remote.TransportType, headers, runtimeConfig.RedirectURI)
368+
return mcp.NewRemoteToolset(toolset.Remote.URL, toolset.Remote.TransportType, headers, runtimeConfig.RedirectURI), nil
369369

370370
default:
371371
return nil, fmt.Errorf("unknown toolset type: %s", toolset.Type)

pkg/tools/mcp/stdio.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@ import (
66
"iter"
77
"os/exec"
88

9-
"github.com/docker/cagent/pkg/tools"
109
"github.com/modelcontextprotocol/go-sdk/mcp"
10+
11+
"github.com/docker/cagent/pkg/tools"
1112
)
1213

1314
type stdioMCPClient struct {

pkg/tools/mcp/toolset.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,14 @@ func NewToolsetCommand(command string, args, env []string) *Toolset {
4949
}
5050

5151
// NewRemoteToolset creates a new MCP toolset from a remote MCP Server.
52-
func NewRemoteToolset(url, transport string, headers map[string]string, redirectURI string) (*Toolset, error) {
52+
func NewRemoteToolset(url, transport string, headers map[string]string, redirectURI string) *Toolset {
5353
slog.Debug("Creating Remote MCP toolset", "url", url, "transport", transport, "headers", headers, "redirectURI", redirectURI)
5454

5555
return &Toolset{
5656
mcpClient: newRemoteClient(url, transport, headers, redirectURI, NewInMemoryTokenStore()),
5757
logType: "remote",
5858
logID: url,
59-
}, nil
59+
}
6060
}
6161

6262
func (ts *Toolset) Start(ctx context.Context) error {

0 commit comments

Comments
 (0)