Merge pull request #2040 from dgageot/board/can-the-recently-added-tools-resultsucce-26689036

dgageot · web-flow · commit bc9f35aaa2cc · 2026-03-10T17:03:23.000+01:00
Use ResultSuccess/ResultError helpers in tasks and user_prompt tools
diff --git a/pkg/tools/builtin/tasks.go b/pkg/tools/builtin/tasks.go
@@ -459,9 +459,7 @@ func (t *TasksTool) nextTask(_ context.Context, _ tools.ToolCall) (*tools.ToolCa
 		}
 	}
 
-	return &tools.ToolCallResult{
-		Output: "No actionable tasks. Everything is either done or blocked.",
-	}, nil
+	return tools.ResultSuccess("No actionable tasks. Everything is either done or blocked."), nil
 }
 
 func (t *TasksTool) addDependency(_ context.Context, params AddDependencyArgs) (*tools.ToolCallResult, error) {
diff --git a/pkg/tools/builtin/user_prompt.go b/pkg/tools/builtin/user_prompt.go
@@ -74,10 +74,7 @@ func (t *UserPromptTool) userPrompt(ctx context.Context, params UserPromptArgs)
 	}
 
 	if result.Action != tools.ElicitationActionAccept {
-		return &tools.ToolCallResult{
-			Output:  string(responseJSON),
-			IsError: true,
-		}, nil
+		return tools.ResultError(string(responseJSON)), nil
 	}
 
 	return tools.ResultSuccess(string(responseJSON)), nil

Original file line number	Diff line number	Diff line change
`@@ -459,9 +459,7 @@ func (t TasksTool) nextTask(_ context.Context, _ tools.ToolCall) (tools.ToolCa`
`459`	`459`	`}`
`460`	`460`	`}`
`461`	`461`
`462`		`- return &tools.ToolCallResult{`
`463`		`- Output: "No actionable tasks. Everything is either done or blocked.",`
`464`		`- }, nil`
	`462`	`+ return tools.ResultSuccess("No actionable tasks. Everything is either done or blocked."), nil`
`465`	`463`	`}`
`466`	`464`
`467`	`465`	`func (t TasksTool) addDependency(_ context.Context, params AddDependencyArgs) (tools.ToolCallResult, error) {`
Original file line number	Diff line number	Diff line change
`@@ -74,10 +74,7 @@ func (t *UserPromptTool) userPrompt(ctx context.Context, params UserPromptArgs)`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`if result.Action != tools.ElicitationActionAccept {`
`77`		`- return &tools.ToolCallResult{`
`78`		`- Output: string(responseJSON),`
`79`		`- IsError: true,`
`80`		`- }, nil`
	`77`	`+ return tools.ResultError(string(responseJSON)), nil`
`81`	`78`	`}`
`82`	`79`
`83`	`80`	`return tools.ResultSuccess(string(responseJSON)), nil`