Merge pull request #832 from dgageot/rename-bg-tool

Rename run_shell_background to run_background_job

Author: dgageot

pkg/tools/builtin/shell.go

@@ -19,7 +19,7 @@ import (
 
 const (
 	ToolNameShell              = "shell"
-	ToolNameRunShellBackground = "run_shell_background"
+	ToolNameRunShellBackground = "run_background_job"
 	ToolNameListBackgroundJobs = "list_background_jobs"
 	ToolNameViewBackgroundJob  = "view_background_job"
 	ToolNameStopBackgroundJob  = "stop_background_job"
@@ -556,7 +556,7 @@ Run long-running processes in the background while continuing with other tasks.
 
 ## Background Job Tools
 
-**run_shell_background**: Start a command in the background
+**run_background_job**: Start a command in the background
 - Parameters: cmd (required), cwd (optional, defaults to ".")
 - Returns: Job ID for tracking
 
@@ -616,8 +616,8 @@ Use list_background_jobs to see all jobs with their status
 { "cmd": "docker run --rm -p 5432:5432 postgres:latest", "cwd": "." }
 
 **Multiple services pattern:**
-1. Start backend: run_shell_background with server command
-2. Start frontend: run_shell_background with dev server
+1. Start backend: run_background_job with server command
+2. Start frontend: run_background_job with dev server
 3. Perform tasks: use other tools while services run
 4. Check logs: view_background_job to see service output
 5. Cleanup: stop_background_job for each service (or let agent cleanup automatically)`

pkg/tools/builtin/shell_test.go

@@ -243,10 +243,9 @@ func TestShellTool_RunBackgroundJob(t *testing.T) {
 	require.NoError(t, err)
 	require.Len(t, tls, 5)
 
-	// Find the run_shell_background tool
 	var handler tools.ToolHandler
 	for _, tl := range tls {
-		if tl.Name == "run_shell_background" {
+		if tl.Name == "run_background_job" {
 			handler = tl.Handler
 			break
 		}
@@ -261,7 +260,7 @@ func TestShellTool_RunBackgroundJob(t *testing.T) {
 
 	toolCall := tools.ToolCall{
 		Function: tools.FunctionCall{
-			Name:      "run_shell_background",
+			Name:      "run_background_job",
 			Arguments: string(argsBytes),
 		},
 	}
@@ -285,7 +284,7 @@ func TestShellTool_ListBackgroundJobs(t *testing.T) {
 
 	var runHandler, listHandler tools.ToolHandler
 	for _, tl := range tls {
-		if tl.Name == "run_shell_background" {
+		if tl.Name == "run_background_job" {
 			runHandler = tl.Handler
 		}
 		if tl.Name == "list_background_jobs" {
@@ -304,7 +303,7 @@ func TestShellTool_ListBackgroundJobs(t *testing.T) {
 
 	_, err = runHandler(t.Context(), tools.ToolCall{
 		Function: tools.FunctionCall{
-			Name:      "run_shell_background",
+			Name:      "run_background_job",
 			Arguments: string(argsBytes),
 		},
 	})