Don't cache messages

rumpl · rumpl · commit d455fb617c7e · 2025-10-23T17:41:21.000+02:00
renderItem already caches what needs to be cached Fixes #441 Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
diff --git a/pkg/tui/components/messages/messages.go b/pkg/tui/components/messages/messages.go
@@ -370,9 +370,6 @@ func (m *model) ensureAllItemsRendered() {
 			allLines = append(allLines, "")
 			currentPosition += 1
 		}
-
-		// Update cache with position information
-		m.renderedItems[i] = item
 	}
 
 	m.rendered = strings.Join(allLines, "\n")

Original file line number	Diff line number	Diff line change
`@@ -370,9 +370,6 @@ func (m *model) ensureAllItemsRendered() {`
`370`	`370`	`allLines = append(allLines, "")`
`371`	`371`	`currentPosition += 1`
`372`	`372`	`}`
`373`		`-`
`374`		`- // Update cache with position information`
`375`		`- m.renderedItems[i] = item`
`376`	`373`	`}`
`377`	`374`
`378`	`375`	`m.rendered = strings.Join(allLines, "\n")`