Skip to content

Commit e9ad604

Browse files
committed
Address review feedback for nightly scanner agent
- Add rationale comment for documentation agent prioritization (only runs when no bugs/security issues to reduce noise) - Add error handling for reporter agent failures - Add output format for failed issue creation
1 parent 0a5ccaa commit e9ad604

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

.github/agents/nightly-scanner.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ agents:
5858
- If fails: log error, continue to documentation check
5959
- `documentation` - for missing docs
6060
- ONLY run if BOTH security AND bugs returned `NO_ISSUES`
61+
- (Rationale: documentation issues are lower priority; we avoid noise when real bugs exist)
6162
- If fails: log error, continue to reporting
6263
4. Collect findings from each sub-agent (they return text format or `NO_ISSUES`)
6364
5. Filter out any issues where FILE matches patterns from memory
@@ -67,6 +68,8 @@ agents:
6768
- From bugs agent → `CATEGORY: bug`
6869
- From documentation agent → `CATEGORY: documentation`
6970
8. Delegate to `reporter` with the augmented findings
71+
- If reporter fails: output `SCAN COMPLETE (with errors) - Issue creation failed: [error]`
72+
- If reporter succeeds: verify the response contains issue URLs before outputting summary
7073
9. Use `add_memory` to store any new learnings
7174
7275
## Error handling
@@ -126,6 +129,13 @@ agents:
126129
No issues found.
127130
```
128131
132+
If reporter fails to create issues, output:
133+
```
134+
SCAN COMPLETE (with errors)
135+
Findings: N issues detected
136+
Issue creation failed: [error message]
137+
```
138+
129139
toolsets:
130140
- type: filesystem
131141
- type: memory

0 commit comments

Comments
 (0)