Skip to content

Commit f33497a

Browse files
committed
Print results as they are produced
Signed-off-by: David Gageot <david.gageot@docker.com>
1 parent e3514ac commit f33497a

2 files changed

Lines changed: 9 additions & 12 deletions

File tree

cmd/root/eval.go

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,16 +52,11 @@ func (f *evalFlags) runEvalCommand(cmd *cobra.Command, args []string) error {
5252
return err
5353
}
5454

55-
results, err := evaluation.Evaluate(ctx, agents, evalsDir)
56-
if err != nil {
57-
return err
58-
}
59-
60-
for _, result := range results {
55+
_, err = evaluation.Evaluate(ctx, agents, evalsDir, func(result evaluation.Result) {
6156
out.Printf("Eval file: %s\n", result.EvalFile)
6257
out.Printf("Tool trajectory score: %f\n", result.Score.ToolTrajectoryScore)
6358
out.Printf("Rouge-1 score: %f\n", result.Score.Rouge1Score)
64-
}
6559

66-
return nil
60+
})
61+
return err
6762
}

pkg/evaluation/evaluation.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ type Result struct {
2222
EvalFile string
2323
}
2424

25-
func Evaluate(ctx context.Context, t *team.Team, evalsDir string) ([]Result, error) {
25+
func Evaluate(ctx context.Context, t *team.Team, evalsDir string, onResult func(Result)) ([]Result, error) {
2626
evalFiles, err := os.ReadDir(evalsDir)
2727
if err != nil {
2828
return nil, err
@@ -56,11 +56,13 @@ func Evaluate(ctx context.Context, t *team.Team, evalsDir string) ([]Result, err
5656
}
5757

5858
score := score(evals[i].GetAllMessages(), actualMessages)
59-
60-
results = append(results, Result{
59+
result := Result{
6160
Score: score,
6261
EvalFile: evals[i].ID,
63-
})
62+
}
63+
onResult(result)
64+
65+
results = append(results, result)
6466
}
6567

6668
return results, nil

0 commit comments

Comments
 (0)