Skip to content

Commit 1663ba9

Browse files
committed
chore(lint): silence intentional warnings flagged after the v4.3.0 split
library config now allows console.warn / console.error since tsup explicitly preserves them in production builds as diagnostic channels (only console.log is the noise we want to ban). TipTap.tsx renames the rollback-only HyperlinkWithMarkdown import to _HyperlinkWithMarkdown so it matches the no-unused-vars allow pattern (/^_/u), with a comment explaining how to flip back if the mobile sheet pipeline regresses. Made-with: Cursor
1 parent 78463e5 commit 1663ba9

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

packages/eslint-config/library.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@ export default [
1010
files: ['**/*.ts'],
1111
rules: {
1212
'@typescript-eslint/explicit-module-boundary-types': 'warn',
13-
'no-console': 'warn'
13+
// console.warn / console.error survive production builds on purpose
14+
// (tsup keeps them as diagnostic channels); only console.log is noise.
15+
'no-console': ['warn', { allow: ['warn', 'error'] }]
1416
}
1517
}
1618
]

packages/webapp/src/components/TipTap/TipTap.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,10 @@ import { HeadingScale } from './extensions/heading-scale'
5151
import { HeadingActionsExtension } from './extensions/HeadingActions'
5252
import {
5353
HighlightWithMarkdown,
54-
HyperlinkWithMarkdown
54+
// Kept as a roll-back hatch for the legacy markdown-link path; flip the
55+
// import name back to `HyperlinkWithMarkdown` and swap it into `extensions`
56+
// below if the new mobile sheet pipeline regresses.
57+
HyperlinkWithMarkdown as _HyperlinkWithMarkdown
5558
// ImageWithMarkdown
5659
} from './extensions/markdown-extensions'
5760
import { MarkdownPaste } from './extensions/markdown-paste'

0 commit comments

Comments
 (0)