Make Encoding changes and add more rename tests

- Delete encoding rule.
- Check for right encoding in the before and after running all rules in
  FormattingEngine.
- Add more tests to Rename.

Author: Lakshmi Priya Sekar

build.cmd

@@ -16,4 +16,4 @@ IF EXIST "%~dp0src\packages" goto build
 
 :build
 
-"%ProgramFiles(x86)%\MSBuild\14.0\bin\MSBuild.exe" %SOLUTION_PATH% /p:OutDir="%~dp0bin " /nologo /m /v:m /flp:verbosity=normal %*
+"%ProgramFiles(x86)%\MSBuild\14.0\bin\MSBuild.exe" %SOLUTION_PATH% /p:OutDir="%~dp0bin " /nologo /m /v:m /flp:verbosity=normal %*

src/Microsoft.DotNet.CodeFormatting.Tests/Rules/HasUnderScoreInPrivateFieldNamesFormattingRuleTests.cs

@@ -19,7 +19,7 @@ class T
     // some trivia
     private static int m_z;
     // some trivia
-    private int k = 1, m_s = 2;
+    private int k = 1, m_s = 2, rsk_yz = 3, x_y_z;
     // some trivia
     [ThreadStatic] static int r;
     [ThreadStaticAttribute] static int b_r;
@@ -33,7 +33,7 @@ class T
     // some trivia
     private static int s_z;
     // some trivia
-    private int _k = 1, _s = 2;
+    private int _k = 1, _s = 2, _rsk_yz = 3, _y_z;
     // some trivia
     [ThreadStatic]
     static int t_r;

src/Microsoft.DotNet.CodeFormatting/FormattingEngineImplementation.cs

@@ -6,10 +6,12 @@
 using System.ComponentModel.Composition;
 using System.IO;
 using System.Linq;
+using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
 
 using Microsoft.CodeAnalysis;
+using Microsoft.CodeAnalysis.Text;
 
 namespace Microsoft.DotNet.CodeFormatting
 {
@@ -70,10 +72,19 @@ private async Task<bool> ShouldBeProcessedAsync(Document document)
 
         private async Task<Document> RewriteDocumentAsync(Document document, CancellationToken cancellationToken)
         {
+            var docText = await document.GetTextAsync();
+            var originalEncoding = docText.Encoding;
             foreach (var rule in _rules)
                 document = await rule.ProcessAsync(document, cancellationToken);
 
-            return document;
+            return await ChangeEncoding(document, originalEncoding);
+        }
+
+        private async Task<Document> ChangeEncoding(Document document, Encoding encoding)
+        {
+            var text = await document.GetTextAsync();
+            var newText = SourceText.From(text.ToString(), encoding);
+            return document.WithText(newText);
         }
     }
 }

src/Microsoft.DotNet.CodeFormatting/Microsoft.DotNet.CodeFormatting.csproj

@@ -95,7 +95,6 @@
     <Compile Include="Rules\HasNoNewLineBeforeEndBraceFormattingRule.cs" />
     <Compile Include="Rules\HasNoCustomCopyrightHeaderFormattingRule.cs" />
     <Compile Include="Rules\HasPrivateAccessorOnFieldNamesFormattingRule.cs" />
-    <Compile Include="Rules\HasRightEncodingFormattingRule.cs" />
     <Compile Include="Rules\HasUnderScoreInPrivateFieldNamesFormattingRule.cs" />
     <Compile Include="Rules\HasUsingsOutsideOfNamespaceFormattingRule.cs" />
     <Compile Include="Rules\IsFormattedFormattingRule.cs" />