feat: add full verification and failure tracking to installer

Author: draphy

configs/i3/lock.sh

@@ -7,6 +7,10 @@
 set -u
 
 # Source global defaults
+if [ ! -f "${HOME}/.config/environment.d/defaults.conf" ]; then
+    echo "Error: defaults.conf not found" >&2
+    exit 1
+fi
 . "${HOME}/.config/environment.d/defaults.conf"
 
 # Use WALLPAPER from environment.d (expand ~ to $HOME)
@@ -248,9 +252,9 @@ start_sleep_timer
 # Lock screen (blocks until unlocked)
 # Use generated image if available, otherwise plain lock
 if [ -f "$LOCKSCREEN" ]; then
-    $LOCKER -n -i "$LOCKSCREEN"
+    "$LOCKER" -n -i "$LOCKSCREEN"
 else
-    $LOCKER -n -c 000000  # Plain black background
+    "$LOCKER" -n -c 000000  # Plain black background
 fi
 
 # Unlocked - cancel sleep timer

configs/polybar/launch.sh

@@ -4,6 +4,10 @@
 set -u
 
 # Source global defaults
+if [ ! -f "${HOME}/.config/environment.d/defaults.conf" ]; then
+    echo "Error: defaults.conf not found" >&2
+    exit 1
+fi
 . "${HOME}/.config/environment.d/defaults.conf"
 
 # Configuration
@@ -21,7 +25,7 @@ if [ -z "${DISPLAY:-}" ]; then
     exit 1
 fi
 
-if ! command -v $BAR &>/dev/null; then
+if ! command -v "$BAR" &>/dev/null; then
     echo "Error: $BAR is not installed" >&2
     exit 1
 fi
@@ -57,22 +61,22 @@ fi
 
 # Terminate already running bar instances
 if command -v killall &>/dev/null; then
-    killall -q $BAR 2>/dev/null || true
+    killall -q "$BAR" 2>/dev/null || true
 elif command -v pkill &>/dev/null; then
-    pkill -x $BAR 2>/dev/null || true
+    pkill -x "$BAR" 2>/dev/null || true
 fi
 
 # Wait until the processes have been shut down (with timeout)
 shutdown_start=$(date +%s)
-while pgrep -u "$_CACHED_UID" -x $BAR >/dev/null 2>&1; do
+while pgrep -u "$_CACHED_UID" -x "$BAR" >/dev/null 2>&1; do
     current_time=$(date +%s)
     elapsed=$((current_time - shutdown_start))
 
     if [ $elapsed -ge $SHUTDOWN_TIMEOUT ]; then
         echo "Warning: Status bar didn't shut down gracefully, forcing kill" | tee -a "$LOG_FILE"
         # Force kill remaining $BAR processes
         if command -v pkill &>/dev/null; then
-            pkill -9 -u "$_CACHED_UID" -x $BAR 2>/dev/null || true
+            pkill -9 -u "$_CACHED_UID" -x "$BAR" 2>/dev/null || true
         fi
         sleep 0.5
         break
@@ -87,7 +91,7 @@ echo "---" >> "$LOG_FILE"
 echo "[$(date '+%Y-%m-%d %H:%M:%S')] Launching $BAR..." >> "$LOG_FILE"
 
 # Launch $BAR with logging (proper background handling)
-$BAR main >> "$LOG_FILE" 2>&1 &
+"$BAR" main >> "$LOG_FILE" 2>&1 &
 BAR_pid=$!
 
 # Brief wait to check if $BAR started successfully

configs/xprofile

@@ -1,5 +1,5 @@
 # Load Xresources
-[[ -f ~/.Xresources ]] && xrdb -merge ~/.Xresources
+[ -f "$HOME/.Xresources" ] && xrdb -merge "$HOME/.Xresources"
 
 # Qt5/Qt6 theming - use qt5ct for configuration
 export QT_QPA_PLATFORMTHEME=qt5ct
@@ -20,16 +20,16 @@ fi
 
 # Auto-detect network interfaces for polybar (handles USB adapters changing ports)
 # Each module auto-hides when disconnected, so both can be configured
-if [ -f ~/.config/polybar/config.ini ] && [ -w ~/.config/polybar/config.ini ]; then
+if [ -f "$HOME/.config/polybar/config.ini" ] && [ -w "$HOME/.config/polybar/config.ini" ]; then
     # Detect WiFi interface (prefer active/UP one)
     WIFI_IFACE=$(ip link show 2>/dev/null | grep -E "^[0-9]+: wl" | head -1 | awk -F: '{print $2}' | tr -d ' ')
-    if [ -n "$WIFI_IFACE" ] && [[ "$WIFI_IFACE" =~ ^[a-zA-Z0-9_-]+$ ]]; then
-        sed -i "/^\[module\/network-wifi\]/,/^\[module\// s/^interface = .*/interface = $WIFI_IFACE/" ~/.config/polybar/config.ini 2>/dev/null || true
+    if [ -n "$WIFI_IFACE" ] && echo "$WIFI_IFACE" | grep -qE '^[a-zA-Z0-9_-]+$'; then
+        sed -i "/^\[module\/network-wifi\]/,/^\[module\// s/^interface = .*/interface = $WIFI_IFACE/" "$HOME/.config/polybar/config.ini" 2>/dev/null || true
     fi
 
     # Detect Ethernet interface
     ETH_IFACE=$(ip link show 2>/dev/null | grep -E "^[0-9]+: (enp|eth)" | head -1 | awk -F: '{print $2}' | tr -d ' ')
-    if [ -n "$ETH_IFACE" ] && [[ "$ETH_IFACE" =~ ^[a-zA-Z0-9_-]+$ ]]; then
-        sed -i "/^\[module\/network-eth\]/,/^\[module\// s/^interface = .*/interface = $ETH_IFACE/" ~/.config/polybar/config.ini 2>/dev/null || true
+    if [ -n "$ETH_IFACE" ] && echo "$ETH_IFACE" | grep -qE '^[a-zA-Z0-9_-]+$'; then
+        sed -i "/^\[module\/network-eth\]/,/^\[module\// s/^interface = .*/interface = $ETH_IFACE/" "$HOME/.config/polybar/config.ini" 2>/dev/null || true
     fi
 fi