fix: shell syntax

Author: draphy

configs/i3/lock.sh

@@ -34,7 +34,7 @@ start_sleep_timer() {
 # Cancel sleep timer
 cancel_sleep_timer() {
     if [ -f "$SLEEP_TIMER_PID" ]; then
-        kill $(cat "$SLEEP_TIMER_PID") 2>/dev/null
+        kill "$(cat "$SLEEP_TIMER_PID")" 2>/dev/null
         rm -f "$SLEEP_TIMER_PID"
     fi
 }

install.sh

@@ -132,7 +132,7 @@ check_sudo() {
     # Keep sudo alive in background
     (while true; do sudo -v; sleep 50; done) &
     SUDO_KEEPER_PID=$!
-    trap "kill $SUDO_KEEPER_PID 2>/dev/null; cleanup" EXIT
+    trap 'kill $SUDO_KEEPER_PID 2>/dev/null; cleanup' EXIT
 
     print_success "Sudo access OK"
 }
@@ -172,7 +172,7 @@ setup_repo() {
     if [ -d "$INSTALL_DIR" ]; then
         if [ -d "$INSTALL_DIR/.git" ]; then
             print_step "Updating existing installation..."
-            cd "$INSTALL_DIR"
+            cd "$INSTALL_DIR" || return
             git fetch --quiet origin 2>/dev/null || true
             git reset --hard origin/latest --quiet 2>/dev/null || git pull --quiet 2>/dev/null || true
         else
@@ -390,14 +390,21 @@ configure_hardware() {
 
     # If it's a symlink, copy to real file for editing
     if [ -L "$polybar_config" ]; then
-        local target=$(readlink -f "$polybar_config")
+        local target
+        target=$(readlink -f "$polybar_config")
         rm -f "$polybar_config"
         cp "$target" "$polybar_config"
     fi
 
     # Detect battery (for laptops)
-    BATTERY=$(ls /sys/class/power_supply/ 2>/dev/null | grep -E "^BAT" | head -1 || echo "")
-    ADAPTER=$(ls /sys/class/power_supply/ 2>/dev/null | grep -E "^AC|^ACAD|^ADP" | head -1 || echo "")
+    BATTERY=""
+    for bat in /sys/class/power_supply/BAT*; do
+        [ -e "$bat" ] && BATTERY=$(basename "$bat") && break
+    done
+    ADAPTER=""
+    for adp in /sys/class/power_supply/AC* /sys/class/power_supply/ACAD* /sys/class/power_supply/ADP*; do
+        [ -e "$adp" ] && ADAPTER=$(basename "$adp") && break
+    done
 
     if [ -n "$BATTERY" ]; then
         print_step "Battery detected: $BATTERY"
@@ -516,7 +523,8 @@ configure_battery_limit() {
     read -r response </dev/tty || response="n"
 
     if [[ "$response" =~ ^[Yy]$ ]]; then
-        local bat_name=$(basename $(dirname "$battery_path"))
+        local bat_name
+        bat_name=$(basename "$(dirname "$battery_path")")
 
         echo 80 | sudo tee "$battery_path" > /dev/null 2>&1
 

uninstall.sh

@@ -95,15 +95,17 @@ remove_configs() {
 
 # Revert fish shell to bash (optional)
 revert_shell() {
-    local current_shell=$(basename "$SHELL")
+    local current_shell
+    current_shell=$(basename "$SHELL")
 
     if [ "$current_shell" = "fish" ]; then
         echo -e "Your default shell is currently ${YELLOW}fish${NC}."
         echo -e "Do you want to revert to ${GREEN}bash${NC}? (y/n)"
         read -r response
 
         if [[ "$response" =~ ^[Yy]$ ]]; then
-            local bash_path=$(command -v bash)
+            local bash_path
+            bash_path=$(command -v bash)
             if [ -n "$bash_path" ]; then
                 print_step "Reverting shell to bash..."
                 if sudo chsh -s "$bash_path" "$USER" 2>/dev/null || chsh -s "$bash_path" 2>/dev/null; then