Issue #2846596 by floretan: RemoteId fields cannot use "0" as a value

floretan · bojanz · commit 448951106fea · 2017-03-02T14:25:01.000+01:00
diff --git a/src/Plugin/Field/FieldType/RemoteIdItem.php b/src/Plugin/Field/FieldType/RemoteIdItem.php
@@ -66,7 +66,7 @@ public static function mainPropertyName() {
    * {@inheritdoc}
    */
   public function isEmpty() {
-    return empty($this->provider) || empty($this->remote_id);
+    return empty($this->provider) || $this->remote_id === NULL || $this->remote_id === '';
   }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ public static function mainPropertyName() {`
`66`	`66`	`* {@inheritdoc}`
`67`	`67`	`*/`
`68`	`68`	`public function isEmpty() {`
`69`		`- return empty($this->provider) \|\| empty($this->remote_id);`
	`69`	`+ return empty($this->provider) \|\| $this->remote_id === NULL \|\| $this->remote_id === '';`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`}`