atm: zatm: fix memcmp casting

i1brnkv · davem330 · commit f9c6442a8f0b · 2018-05-29T09:59:53.000-04:00
memcmp() returns int, but eprom_try_esi() cast it to unsigned char. One
can lose significant bits and get 0 from non-0 value returned by the
memcmp().

Signed-off-by: Ivan Bornyakov &lt;brnkv.i1@gmail.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/atm/zatm.c b/drivers/atm/zatm.c
@@ -1151,8 +1151,8 @@ static void eprom_get_byte(struct zatm_dev *zatm_dev, unsigned char *byte,
 }
 
 
-static unsigned char eprom_try_esi(struct atm_dev *dev, unsigned short cmd,
-				   int offset, int swap)
+static int eprom_try_esi(struct atm_dev *dev, unsigned short cmd, int offset,
+			 int swap)
 {
 	unsigned char buf[ZEPROM_SIZE];
 	struct zatm_dev *zatm_dev;

Original file line number	Diff line number	Diff line change
`@@ -1151,8 +1151,8 @@ static void eprom_get_byte(struct zatm_dev zatm_dev, unsigned char byte,`
`1151`	`1151`	`}`
`1152`	`1152`
`1153`	`1153`
`1154`		`-static unsigned char eprom_try_esi(struct atm_dev *dev, unsigned short cmd,`
`1155`		`- int offset, int swap)`
	`1154`	`+static int eprom_try_esi(struct atm_dev *dev, unsigned short cmd, int offset,`
	`1155`	`+ int swap)`
`1156`	`1156`	`{`
`1157`	`1157`	`unsigned char buf[ZEPROM_SIZE];`
`1158`	`1158`	`struct zatm_dev *zatm_dev;`