Skip to content

Commit 2e9af72

Browse files
committed
simplify context-menu-example with ember-event-helpers
1 parent fc990b4 commit 2e9af72

5 files changed

Lines changed: 9 additions & 14 deletions

File tree

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@
6666
"ember-crumbly": "^3.0.1",
6767
"ember-data": "^3.24.0",
6868
"ember-disable-prototype-extensions": "^1.1.3",
69+
"ember-event-helpers": "^0.1.1",
6970
"ember-export-application-global": "^2.0.1",
7071
"ember-load-initializers": "^2.1.2",
7172
"ember-maybe-import-regenerator": "^0.1.6",

tests/dummy/app/components/context-menu-example/content.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{{! BEGIN-SNIPPET context-menu-content.hbs }}
22
<BasicDropdown as |dd|>
3-
<dd.Trigger {{on "contextmenu" (fn this.openContextMenu dd)}}>
3+
<dd.Trigger {{on "contextmenu" (prevent-default dd.actions.open)}}>
44
{{@node.content}}
55
</dd.Trigger>
66
<dd.Content class="context-menu-example--dropdown-content">

tests/dummy/app/components/context-menu-example/content.js

Lines changed: 0 additions & 12 deletions
This file was deleted.

tests/dummy/app/components/demo-context-menu.hbs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,5 @@
44
</demo.example>
55
<demo.snippet @name="context-menu-example.hbs"/>
66
<demo.snippet @label="content.hbs" @name="context-menu-content.hbs"/>
7-
<demo.snippet @label="content.js" @name="context-menu-content.js"/>
87
<demo.snippet @label="custom-menu.hbs" @name="context-menu-custom-menu.hbs"/>
98
</DocsDemo>

yarn.lock

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7153,6 +7153,13 @@ ember-element-helper@^0.5.0, ember-element-helper@^0.5.5:
71537153
ember-cli-babel "^7.17.2"
71547154
ember-cli-htmlbars "^5.1.0"
71557155

7156+
ember-event-helpers@^0.1.1:
7157+
version "0.1.1"
7158+
resolved "https://registry.yarnpkg.com/ember-event-helpers/-/ember-event-helpers-0.1.1.tgz#8df141306c927b9d1a7bc63d63095e92c0ba90a1"
7159+
integrity sha512-fWcbWd4W4nRv8bbato8JB6oGRpATkR+oGYxMIqnfgTgPWaCS0ww7CuUVNpwg1TulojKMCuTXi8Fem2b1NSF1ZQ==
7160+
dependencies:
7161+
ember-cli-babel "^7.19.0"
7162+
71567163
ember-export-application-global@^2.0.1:
71577164
version "2.0.1"
71587165
resolved "https://registry.yarnpkg.com/ember-export-application-global/-/ember-export-application-global-2.0.1.tgz#b120a70e322ab208defc9e2daebe8d0dfc2dcd46"

0 commit comments

Comments
 (0)