Skip to content

Commit b0e29f6

Browse files
committed
Merge branch 'master' into improve-docs
# Conflicts: # package.json # yarn.lock
2 parents 62e2cd8 + eea5c6e commit b0e29f6

12 files changed

Lines changed: 98 additions & 205 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
#$ - scenario: ember-default-with-jquery
2424
#$ - scenario: ember-classic
2525
#$ - scenario: embroider-safe
26-
#$ - scenario: embroider-optimized
2726
#$ nodeVersion: 12.x
2827
#$ packageManager: yarn
2928
#
@@ -181,8 +180,7 @@ jobs:
181180
ember-canary,
182181
ember-default-with-jquery,
183182
ember-classic,
184-
embroider-safe,
185-
embroider-optimized
183+
embroider-safe
186184
]
187185

188186
steps:

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ jobs:
5454
- env: EMBER_TRY_SCENARIO=ember-default-with-jquery
5555
- env: EMBER_TRY_SCENARIO=ember-classic
5656
- env: EMBER_TRY_SCENARIO=embroider-safe
57-
- env: EMBER_TRY_SCENARIO=embroider-optimized
57+
# - env: EMBER_TRY_SCENARIO=embroider-optimized
5858

5959
before_install:
6060
- curl -o- -L https://yarnpkg.com/install.sh | bash

ember-cli-build.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ const EmberAddon = require('ember-cli/lib/broccoli/ember-addon');
55
module.exports = function (defaults) {
66
let app = new EmberAddon(defaults, {
77
'ember-bootstrap': {
8-
bootstrapVersion: 3,
9-
importBootstrapFont: true,
8+
bootstrapVersion: 5,
9+
importBootstrapFont: false,
1010
importBootstrapCSS: false,
1111
},
1212
snippetSearchPaths: ['addon', 'tests/dummy/app'],

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,11 @@
4646
"@glimmer/component": "^1.0.4",
4747
"@glimmer/tracking": "^1.0.4",
4848
"babel-eslint": "^10.1.0",
49-
"bootstrap-sass": "^3.3.7",
49+
"bootstrap": "^5.0.0",
5050
"broccoli-asset-rev": "^3.0.0",
5151
"ember-auto-import": "^2.2.4",
5252
"ember-basic-dropdown": "^4.0.1",
53-
"ember-bootstrap": "^4.6.2",
53+
"ember-bootstrap": "^5.0.0-beta.2",
5454
"ember-cli": "~3.28.4",
5555
"ember-cli-addon-docs": "^4.2.1",
5656
"ember-cli-addon-docs-yuidoc": "^1.0.0",
@@ -65,7 +65,6 @@
6565
"ember-click-outside": "^2.0.0",
6666
"ember-concurrency": "^2.2.0",
6767
"ember-concurrency-decorators": "^2.0.3",
68-
"ember-crumbly": "^3.0.1",
6968
"ember-data": "^3.24.0",
7069
"ember-disable-prototype-extensions": "^1.1.3",
7170
"ember-event-helpers": "^0.1.1",
@@ -76,7 +75,7 @@
7675
"ember-page-title": "^6.2.2",
7776
"ember-qunit": "^5.1.4",
7877
"ember-resolver": "^8.0.2",
79-
"ember-simple-set-helper": "^0.1.2",
78+
"ember-set-helper": "^2.0.1",
8079
"ember-source": "~3.28.0",
8180
"ember-source-channel-url": "^3.0.0",
8281
"ember-template-lint": "^3.6.0",
@@ -96,6 +95,7 @@
9695
"webpack": "^5.65.0"
9796
},
9897
"resolutions": {
98+
"ember-raf-scheduler": "^0.3.0",
9999
"ember-svg-jar": "^2.3.3"
100100
},
101101
"engines": {

tests/dummy/app/components/demo-navigation.hbs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
<demo.example @name="demo-navigation.hbs">
33
<NavigationExample/>
44
</demo.example>
5-
<demo.snippet @name="navigation-example.hbs"/>
5+
<demo.snippet @label="component.hbs" @name="navigation-example.hbs"/>
6+
<demo.snippet @label="component.js" @name="navigation-example.js"/>
67
<demo.snippet @label="content.hbs" @name="navigation-content.hbs"/>
78
<demo.snippet @label="router.js" @name="navigation.js"/>
89
</DocsDemo>

tests/dummy/app/components/navigation-example/index.hbs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
<div class="navigation-example">
22
{{! BEGIN-SNIPPET navigation-example.hbs }}
3-
<BreadCrumbs @outputStyle="bootstrap" @linkable={{false}}/>
3+
Current route:
4+
5+
<span class="text-monospace">
6+
{{this.router.currentRouteName}}
7+
</span>
48

59
<BasicTree @contentComponent={{component "navigation-example/content"}} as |tree|>
610
<tree.Node @label="root" @route="docs.examples.navigation" @isExpanded={{true}}>
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
// BEGIN-SNIPPET navigation-example.js
2+
import Component from '@glimmer/component';
3+
import { inject as service } from '@ember/service';
4+
5+
export default class extends Component {
6+
@service router;
7+
}
8+
// END-SNIPPET

tests/dummy/app/components/recursive-example/children.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
@directory={{directory}}
77
@isExpandable={{true}}
88
@isExpanded={{directory.isExpanded}}
9-
@onExpanded={{set directory.isExpanded}}
9+
@onExpanded={{set directory "isExpanded"}}
1010
/>
1111
{{/each}}
1212
{{#each @node.directory.files as |file|}}

tests/dummy/app/components/recursive-example/index.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
@directory={{@root}}
88
@isExpandable={{true}}
99
@isExpanded={{@root.isExpanded}}
10-
@onExpanded={{set @root.isExpanded}}
10+
@onExpanded={{set @root "isExpanded"}}
1111
/>
1212
</BasicTree>
1313
{{! END-SNIPPET }}

tests/dummy/app/styles/app.scss

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,12 @@
2424
.navigation-example-link {
2525
margin: 1px 2px;
2626
padding: 1px 3px;
27+
text-decoration: none;
2728
border-radius: $nav-pills-border-radius;
2829

29-
&:hover,
30-
&:focus {
31-
text-decoration: none;
32-
background-color: $nav-link-hover-bg;
33-
}
34-
3530
&.active {
36-
color: $nav-pills-active-link-hover-color;
37-
background-color: $nav-pills-active-link-hover-bg;
31+
color: $nav-pills-link-active-color;
32+
background-color: $nav-pills-link-active-bg;
3833
}
3934
}
4035
}

0 commit comments

Comments
 (0)