Skip to content

Commit b3f4740

Browse files
committed
Addressed most of Alex' review points. Still need to address copyright (and possibly licence for RooDataEntity...???)
1 parent b27c830 commit b3f4740

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

rocrate_validator/profiles/five-safes-crate/must/2_requesting_agent.ttl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
five-safes-crate:CreateActionHasAgent
2727
a sh:NodeShape ;
28-
sh:name: "CreateAction" ;
28+
sh:name "CreateAction" ;
2929
sh:targetClass schema:CreateAction ;
3030
sh:description "Checks that a CreateAction has an agent and that each agent is a schema:Person." ;
3131

@@ -45,6 +45,7 @@ five-safes-crate:CreateActionHasAgent
4545
a sh:PropertyShape ;
4646
sh:name "Agent is a Person" ;
4747
sh:path schema:agent ;
48+
sh:nodeKind sh:IRI ;
4849
sh:class schema:Person ;
4950
sh:severity sh:Violation ;
5051
sh:message "Each CreateAction agent MUST be typed as schema:Person and be an IRI." ;

rocrate_validator/profiles/five-safes-crate/should/2_requesting_agent.ttl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ five-safes-crate:PersonAgentHasAffiliation
2626

2727
# The agent of a CreateAction entity SHOULD have an affiliation
2828
sh:property [
29+
a sh:PropertyShape ;
2930
sh:name "Presence of affiliations" ;
3031
sh:path schema:affiliation ;
3132
sh:minCount 1 ;
@@ -40,11 +41,10 @@ five-safes-crate:PersonAgentHasAffiliation
4041
sh:path schema:affiliation ;
4142
sh:nodeKind sh:IRI ;
4243
sh:or (
43-
[ sh:pattern "^https://ror\\.org/0[0-9a-hjkmnp-tv-z]{6}[0-9]{2}$" ]
44-
[ sh:pattern "^https://isni\\.org/isni/\\d{15}[\\dX]$" ]
45-
[ sh:pattern "^https://(?:www\\.)?wikidata\\.org/entity/Q\\d+$" ]
44+
[ sh:pattern "^https://ror\\.org/0[0-9a-hjkmnp-tv-z]{6}[0-9]{2}$" ; sh:flags "i"]
45+
[ sh:pattern "^https://isni\\.org/isni/\\d{15}[\\dX]$" ; sh:flags "i"]
46+
[ sh:pattern "^https://(?:www\\.)?wikidata\\.org/entity/Q\\d+$" ; sh:flags "i"]
4647
) ;
47-
sh:flags "i" ;
4848
sh:severity sh:Warning ;
4949
sh:message "Affiliation Organization @id SHOULD be a permalink (ROR/ISNI/Wikidata)." ;
5050
] .

0 commit comments

Comments
 (0)