Methods documentation.

Author: andrew-svirin

phpstan.neon

@@ -2,6 +2,3 @@ parameters:
     level: 7
     paths:
         - src
-    ignoreErrors:
-        - '#has no value type specified in iterable type#'
-        - '#generic class .+ does not specify its types#'

src/Contexts/BTFContext.php

@@ -10,6 +10,7 @@
  */
 abstract class BTFContext extends ServiceContext
 {
+    /** @var array<string, string> */
     private array $parameters = [];
 
     public function setParameter(string $name, string $value): self
@@ -19,6 +20,7 @@ public function setParameter(string $name, string $value): self
         return $this;
     }
 
+    /** @return array<string, string> */
     public function getParameters(): array
     {
         return $this->parameters;

src/Contexts/FFLContext.php

@@ -13,6 +13,7 @@
 abstract class FFLContext implements OrderContextInterface
 {
     private string $fileFormat;
+    /** @var array<string, string> */
     private array $parameters = [];
     private ?string $countryCode = null;
 
@@ -35,6 +36,7 @@ public function setParameter(string $name, string $value): self
         return $this;
     }
 
+    /** @return array<string, string> */
     public function getParameters(): array
     {
         return $this->parameters;

src/Contracts/Crypt/ASN1Interface.php

@@ -30,7 +30,7 @@ public function loadOIDs(array $oids);
      *
      * @param string $encoded Bytes.
      *
-     * @return array
+     * @return array<int, array<string, mixed>|false>
      */
     public function decodeBER(string $encoded);
 
@@ -45,7 +45,7 @@ public function decodeBER(string $encoded);
      * @param array<string, mixed> $mapping
      * @param array<string, callable> $special
      *
-     * @return array|string|false|null
+     * @return list<array<int|string, mixed>|string|false|null>|array<int|string, mixed>|string|false|null
      */
     public function asn1map(array $decoded, array $mapping, array $special = []);
 
@@ -91,14 +91,14 @@ public function convert(string $in, int $from = ASN1::TYPE_UTF8_STRING, int $to
     /**
      * Get property ANYmap.
      *
-     * @return array
+     * @return array<int, bool|string>
      */
     public function getANYmap();
 
     /**
      * Get property stringTypeSize.
      *
-     * @return array
+     * @return array<int, int>
      */
     public function getStringTypeSize();
 }

src/Contracts/Crypt/BigIntegerInterface.php

@@ -147,7 +147,7 @@ public function modInverse(BigIntegerInterface $n);
      *
      * @param BigIntegerInterface $y
      *
-     * @return array
+     * @return array{0: BigIntegerInterface, 1: BigIntegerInterface}
      * @internal This function is based off of
      *    {@link http://www.cacr.math.uwaterloo.ca/hac/about/chap14.pdf#page=9 HAC 14.20}.
      */

src/Contracts/Crypt/X509Interface.php

@@ -183,7 +183,7 @@ public function computeKeyIdentifier($key = null);
     /**
      * Format a public key as appropriate.
      *
-     * @return array|null
+     * @return array<string, mixed>|null
      */
     public function formatSubjectPublicKey(): ?array;
 

src/Contracts/EbicsClientInterface.php

@@ -64,10 +64,13 @@ public function createUserSignatures(?array $options = null): void;
      *
      * The certificate is used in the INI/HIA/H3K initialization processes.
      *
-     * @return array Certificate data array containing:
-     *   - 'certificate': The X.509 certificate in PEM format
-     *   - 'private_key': The corresponding private key
-     *   - 'public_key': The corresponding public key
+     * @return array{
+     *     publickey: mixed,
+     *     publickey_type: int,
+     *     privatekey: mixed,
+     *     privatekey_type: int,
+     *     certificate: string|null
+     * } Certificate data array
      */
     public function generateIssuerCertificate(): array;
 

src/EbicsClient.php

@@ -785,7 +785,8 @@ private function createDownloadOrderResult(
                 $orderResult->setDataFiles($this->documentFactory->createMultipleXml($files));
                 break;
             case self::FILE_PARSER_FORMAT_ZIP_FILES:
-                $orderResult->setDataFiles($this->zipService->extractFilesFromString($orderResult->getData()));
+                $zipFiles = $this->zipService->extractFilesFromString($orderResult->getData());
+                $orderResult->setDataFiles(array_filter($zipFiles, fn($v) => $v !== false));
                 break;
             default:
                 throw new LogicException('Incorrect format');

src/Factories/KeyringFactory.php

@@ -97,7 +97,7 @@ private function buildKeyringFromDataForTypeKeyring(
     /**
      * @param Keyring $keyring
      *
-     * @return array
+     * @return array<string, mixed>
      */
     public function buildDataFromKeyring(Keyring $keyring): array
     {

src/Handlers/AuthSignatureHandler.php

@@ -3,7 +3,9 @@
 namespace EbicsApi\Ebics\Handlers;
 
 use DOMDocument;
+use DOMNameSpaceNode;
 use DOMNode;
+use DOMNodeList;
 use EbicsApi\Ebics\Exceptions\EbicsException;
 use EbicsApi\Ebics\Handlers\Traits\C14NTrait;
 use EbicsApi\Ebics\Handlers\Traits\H00XTrait;