fixes bug where retrieve_url is modified in place, increments result ids properly in solr_retrieve_list

Author: bmckinney-ebsco

CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). 
 
+## [1.0.4] - 2018-10-29
+### Fixed
+- List retrieval returns a repeating list of just the first record. 
+- List retrieval fails to increment the EDS result id.
+
 ## [1.0.3] - 2018-10-18
 ### Changed
 - Citation style and export links can now be removed entirely or replaced by specifying regular expressions in several configuration options that can include ruby erb variable expressions for an item's `dbid` and `an`. This was added to address situations where customer proxy urls are returned. See: [Citation link replacement](https://github.com/ebsco/edsapi-ruby/wiki/Citation-link-replacement)
@@ -70,6 +75,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ### Added
 - Adds KW (keywords) and SH (subject heading) to solr search fields
 
+[1.0.4]: https://github.com/ebsco/edsapi-ruby/compare/1.0.3...1.0.4
 [1.0.3]: https://github.com/ebsco/edsapi-ruby/compare/1.0.2...1.0.3
 [1.0.2]: https://github.com/ebsco/edsapi-ruby/compare/1.0.1...1.0.2
 [1.0.1]: https://github.com/ebsco/edsapi-ruby/compare/1.0.0...1.0.1

lib/ebsco/eds/session.rb

@@ -459,10 +459,12 @@ def solr_retrieve_previous_next(options = {})
       def solr_retrieve_list(list: [], highlight: nil)
         records = []
         if list.any?
-          list.each { |id|
+          list.each.with_index(1) { |id, index|
             dbid = id.split('__',2).first
             accession = id.split('__',2).last
-            records.push retrieve(dbid: dbid, an: accession, highlight: highlight, ebook: @config[:ebook_preferred_format])
+            current_rec = retrieve(dbid: dbid, an: accession, highlight: highlight, ebook: @config[:ebook_preferred_format])
+            current_rec.eds_result_id = index
+            records.push current_rec
           }
         end
         r = empty_results(records.length)
@@ -795,6 +797,8 @@ def do_request(method, path:, payload: nil, attempt: 0) # :nodoc:
 
           conn = connection
 
+          config_path = path.dup
+
           # use a citation api connection?
           if path.include?(@config[:citation_exports_url]) || path.include?(@config[:citation_styles_url])
             conn = citation_connection
@@ -805,18 +809,18 @@ def do_request(method, path:, payload: nil, attempt: 0) # :nodoc:
               when :get
                 unless payload.nil?
                   qs = CGI.unescape(payload.to_query(nil))
-                  path << '?' + qs
+                  config_path << '?' + qs
                 end
-               req.url path
+               req.url config_path
               when :post
                 unless payload.nil?
                   json_payload = JSON.generate(payload)
-                  path << get_cache_id(path, json_payload) if @use_cache
+                  config_path << get_cache_id(path, json_payload) if @use_cache
                   req.body = json_payload
                 end
-                req.url path
+                req.url config_path
               else
-                raise EBSCO::EDS::ApiError, "EBSCO API error: Method #{method} not supported for endpoint #{path}"
+                raise EBSCO::EDS::ApiError, "EBSCO API error: Method #{method} not supported for endpoint #{config_path}"
             end
           end
           resp.body

lib/ebsco/eds/version.rb

@@ -1,5 +1,5 @@
 module EBSCO
   module EDS
-    VERSION = '1.0.3'
+    VERSION = '1.0.4'
   end
 end