Skip to content

Commit 2dee28e

Browse files
Align preventReactFlowEvents default value (true) in Modal and SimpleDialog
1 parent b8b965f commit 2dee28e

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

src/components/Dialog/Modal.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ import {
55
Overlay2Props as BlueprintOverlayProps,
66
} from "@blueprintjs/core";
77

8+
import { preventReactFlowActionsClasses } from "../../cmem";
89
import { utils } from "../../common";
910
import { CLASSPREFIX as eccgui } from "../../configuration/constants";
1011
import { TestableComponent } from "../interfaces";
1112

1213
import { Card } from "./../Card";
13-
import {preventReactFlowActionsClasses} from "../../cmem";
1414

1515
export interface ModalProps extends TestableComponent, BlueprintOverlayProps {
1616
children: React.ReactNode | React.ReactNode[];
@@ -47,7 +47,7 @@ export interface ModalProps extends TestableComponent, BlueprintOverlayProps {
4747
preventReactFlowEvents?: boolean;
4848
}
4949

50-
export type ModalSize = "tiny" | "small" | "regular" | "large" | "xlarge" | "fullscreen"
50+
export type ModalSize = "tiny" | "small" | "regular" | "large" | "xlarge" | "fullscreen";
5151

5252
/**
5353
* Displays contents on top of other elements, used to create dialogs.
@@ -70,7 +70,7 @@ export const Modal = ({
7070
onOpening,
7171
"data-test-id": dataTestId,
7272
"data-testid": dataTestid,
73-
preventReactFlowEvents = false,
73+
preventReactFlowEvents = true,
7474
...otherProps
7575
}: ModalProps) => {
7676
const backdropProps: React.HTMLProps<HTMLDivElement> | undefined =

src/components/Dialog/SimpleDialog.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ export const SimpleDialog = ({
6969
startInFullScreenMode = false,
7070
size,
7171
actionsProps,
72-
preventReactFlowEvents = true,
7372
...otherProps
7473
}: SimpleDialogProps) => {
7574
const [displayFullscreen, setDisplayFullscreen] = React.useState<boolean>(startInFullScreenMode);
@@ -89,7 +88,6 @@ export const SimpleDialog = ({
8988
canOutsideClickClose={canOutsideClickClose || !preventSimpleClosing}
9089
canEscapeKeyClose={canEscapeKeyClose || !preventSimpleClosing}
9190
size={displayFullscreen ? "fullscreen" : size}
92-
preventReactFlowEvents={preventReactFlowEvents}
9391
>
9492
<Card className={intentClassName}>
9593
{title || headerOptions || showToggler ? (

0 commit comments

Comments
 (0)