Skip to content

Commit 9d80cfa

Browse files
fix: compile errors after @setting cleanup (#439)
1 parent 473324a commit 9d80cfa

4 files changed

Lines changed: 5 additions & 7 deletions

File tree

plugins/autodoc/autodoc-processor/src/main/java/org/eclipse/edc/plugins/autodoc/core/processor/introspection/ExtensionIntrospector.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,14 +152,12 @@ private ConfigurationSetting createConfigurationSetting(VariableElement settingE
152152
.toString();
153153

154154
var description = Stream.of(
155-
attributeValue(String.class, "description", settingMirror, elementUtils),
156-
attributeValue(String.class, "value", settingMirror, elementUtils)
155+
attributeValue(String.class, "description", settingMirror, elementUtils)
157156
).filter(Objects::nonNull).filter(it -> !it.isEmpty()).findFirst().orElse(null);
158157

159158
return ConfigurationSetting.Builder.newInstance()
160159
.key(keyValue)
161160
.description(description)
162-
.type(attributeValue(String.class, "type", settingMirror, elementUtils))
163161
.required(attributeValue(Boolean.class, "required", settingMirror, elementUtils))
164162
.maximum(attributeValue(Long.class, "max", settingMirror, elementUtils))
165163
.minimum(attributeValue(Long.class, "min", settingMirror, elementUtils))

plugins/autodoc/autodoc-processor/src/test/java/org/eclipse/edc/plugins/autodoc/core/processor/test/ConfigurationExtensionWithSetting.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
public class ConfigurationExtensionWithSetting implements ConfigurationExtension {
2222

23-
@Setting("Valid because this is an extension of ServiceExtension")
23+
@Setting(description = "Valid because this is an extension of ServiceExtension")
2424
private static final String VALID_SETTING = "any";
2525

2626
@Override

plugins/autodoc/autodoc-processor/src/test/java/org/eclipse/edc/plugins/autodoc/core/processor/test/NotExtensionWithSetting.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@
1717
import org.eclipse.edc.runtime.metamodel.annotation.Setting;
1818

1919
public class NotExtensionWithSetting {
20-
@Setting("the setting must stay in a ServiceExtension class")
20+
@Setting(description = "the setting must stay in a ServiceExtension class")
2121
private static final String UNEXPECTED_SETTING = "any";
2222
}

plugins/autodoc/autodoc-processor/src/test/java/org/eclipse/edc/plugins/autodoc/core/processor/testextensions/SampleExtensionWithoutAnnotation.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@
2525

2626
@Provides(SomeOtherService.class)
2727
public class SampleExtensionWithoutAnnotation implements ServiceExtension {
28-
@Setting(value = Constants.TEST_SETTING_NAME, required = true, defaultValue = TEST_SETTING_DEFAULT_VALUE)
28+
@Setting(description = Constants.TEST_SETTING_NAME, required = true, defaultValue = TEST_SETTING_DEFAULT_VALUE)
2929
public static final String TEST_SETTING = Constants.TEST_SETTING_KEY;
3030

3131
@Deprecated(since = "forever")
32-
@Setting(value = "deprecated")
32+
@Setting(description = "deprecated")
3333
public static final String DEPRECATED_TEST_SETTING = Constants.TEST_DEPRECATED_SETTING_KEY;
3434

3535
@Inject

0 commit comments

Comments
 (0)