style: cleanup code as per @dwalluck's feedback

Author: ctron

rpm/src/main/java/org/eclipse/packager/rpm/app/Dumper.java

@@ -65,7 +65,7 @@ public static String dumpFlag ( final int value, final IntFunction<Optional<?>>
 
     public static void dumpAll ( final RpmInputStream in ) throws IOException
     {
-        final RpmLead lead = in.getLead();
+        final RpmLead lead = in.getLead ();
 
         if ( !SKIP_META )
         {

rpm/src/main/java/org/eclipse/packager/rpm/build/BuilderOptions.java

@@ -159,7 +159,8 @@ public List<PayloadProcessor> getPayloadProcessors ()
 
     public void setPayloadProcessors ( final List<PayloadProcessor> payloadProcessors )
     {
-        this.payloadProcessors = new ArrayList<>(payloadProcessors);
+        // we create a copy of the list to prevent external changes to our state.
+        this.payloadProcessors = new ArrayList<> ( payloadProcessors );
     }
 
     public void addPayloadProcessor ( final PayloadProcessor processor )

rpm/src/main/java/org/eclipse/packager/rpm/build/PayloadProcessors.java

@@ -61,7 +61,7 @@ public void finish ( final Header<RpmTag> header )
                 final String compressed = Hex.toHexString ( digestCompressed.digest () );
                 header.putStringArray ( RpmTag.PAYLOAD_DIGEST, compressed );
                 header.putStringArray ( RpmTag.PAYLOAD_DIGEST_ALT, raw );
-                header.putInt ( RpmTag.PAYLOAD_DIGEST_ALGO, algorithm.getTag() );
+                header.putInt ( RpmTag.PAYLOAD_DIGEST_ALGO, algorithm.getTag () );
             }
         };
     }

rpm/src/main/java/org/eclipse/packager/rpm/build/RpmBuilder.java

@@ -960,7 +960,7 @@ private void fillHeader ( final PayloadRecorder.Finished finished )
 
         // add additional headers
 
-        this.header.putAll ( finished.getAdditionalHeader() );
+        this.header.putAll ( finished.getAdditionalHeader () );
     }
 
     private static void putNumber ( final LongMode longMode, final Header<RpmTag> header, final Collection<FileEntry> files, final RpmTag tag, final ToLongFunction<FileEntry> func )
@@ -1103,12 +1103,12 @@ public void build () throws IOException
 
             leadBuilder.fillFlagsFromHeader ( this.header, createLeadArchitectureMapper (), createLeadOperatingSystemMapper () );
 
-            if ( this.headerCustomizer != null)
+            if ( this.headerCustomizer != null )
             {
-                this.headerCustomizer.accept(this.header);
+                this.headerCustomizer.accept ( this.header );
             }
 
-            try ( final RpmWriter writer = new RpmWriter ( this.targetFile, leadBuilder, this.header, this.options.getHeaderCharset (), this.options.getOpenOptions() ) ) {
+            try ( final RpmWriter writer = new RpmWriter ( this.targetFile, leadBuilder, this.header, this.options.getHeaderCharset (), this.options.getOpenOptions () ) ) {
                 writer.addAllSignatureProcessors ( this.signatureProcessors );
                 writer.setPayload ( finished );
             }

rpm/src/main/java/org/eclipse/packager/rpm/signature/RsaSignatureProcessor.java

@@ -1,4 +1,4 @@
-/**
+/*
  * Copyright (c) 2016, 2022 Contributors to the Eclipse Foundation
  *
  * See the NOTICE file(s) distributed with this work for additional
@@ -36,18 +36,20 @@ public class RsaSignatureProcessor implements SignatureProcessor
 
     private final PGPSignatureGenerator signatureGenerator;
 
-    protected RsaSignatureProcessor(final PGPPrivateKey privateKey, final int hashAlgorithm )
+    protected RsaSignatureProcessor ( final PGPPrivateKey privateKey, final int hashAlgorithm )
     {
         Objects.requireNonNull ( privateKey );
 
-        final BcPGPContentSignerBuilder contentSignerBuilder = new BcPGPContentSignerBuilder ( privateKey.getPublicKeyPacket ().getAlgorithm (), hashAlgorithm);
+        final BcPGPContentSignerBuilder contentSignerBuilder = new BcPGPContentSignerBuilder ( privateKey.getPublicKeyPacket ().getAlgorithm (), hashAlgorithm );
         this.signatureGenerator = new PGPSignatureGenerator ( contentSignerBuilder );
 
-        try {
-            this.signatureGenerator.init ( PGPSignature.BINARY_DOCUMENT, privateKey);
+        try
+        {
+            this.signatureGenerator.init ( PGPSignature.BINARY_DOCUMENT, privateKey );
         }
-        catch ( Exception e ) {
-            throw new RuntimeException(e);
+        catch ( Exception e )
+        {
+            throw new RuntimeException ( e );
         }
     }
 
@@ -100,6 +102,5 @@ public void finish ( final Header<RpmSignatureTag> signature )
         {
             throw new RuntimeException(e);
         }
-
     }
 }