[cleanup] Fix data-testid in InsertTextualSysMLv2Modal

Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

Author: pcdavid

backend/services/syson-sysml-metamodel-services/src/main/java/org/eclipse/syson/sysml/metamodel/services/MetamodelQueryElementService.java

@@ -21,14 +21,12 @@
 import org.eclipse.syson.sysml.ActorMembership;
 import org.eclipse.syson.sysml.Connector;
 import org.eclipse.syson.sysml.Element;
-import org.eclipse.syson.sysml.ElementFilterMembership;
 import org.eclipse.syson.sysml.Expression;
 import org.eclipse.syson.sysml.Feature;
 import org.eclipse.syson.sysml.FeatureValue;
 import org.eclipse.syson.sysml.PartUsage;
 import org.eclipse.syson.sysml.ReferenceUsage;
 import org.eclipse.syson.sysml.StakeholderMembership;
-import org.eclipse.syson.sysml.ResultExpressionMembership;
 import org.eclipse.syson.sysml.SubjectMembership;
 import org.eclipse.syson.sysml.Usage;
 
@@ -91,13 +89,7 @@ public boolean isStakeholder(Element element) {
      * @return true if the element is an actual expression definition.
      */
     public boolean isExpressionDefinition(Element element) {
-        if (element instanceof Expression && !(element instanceof Usage)) {
-            var owningRelationship = element.getOwningRelationship();
-            return owningRelationship instanceof FeatureValue || owningRelationship instanceof ElementFilterMembership
-                    || owningRelationship instanceof ResultExpressionMembership;
-        } else {
-            return false;
-        }
+        return element instanceof Expression && !(element instanceof Usage);
     }
 
     /**

frontend/syson-components/src/extensions/InsertTextualSysMLv2Modal.tsx

@@ -22,7 +22,6 @@ import { Theme } from '@mui/material/styles';
 import TextField from '@mui/material/TextField';
 import { useEffect, useState } from 'react';
 import { makeStyles } from 'tss-react/mui';
-
 import { InsertTextualSysMLv2ModalProps, InsertTextualSysMLv2ModalState } from './InsertTextualSysMLv2Modal.types';
 import { NewObjectAsTextReport } from './NewObjectAsTextDocumentReport';
 import { useInsertTextualSysMLv2 } from './useInsertTextualSysMLv2';
@@ -106,7 +105,7 @@ export const InsertTextualSysMLv2Modal = ({ editingContextId, item, onClose }: I
             onClick={(event) => onInsertTextualSysMLv2(event)}
             startIcon={
               state.insertInProgress ? (
-                <CircularProgress size="20px" data-testid="arrange-all-circular-loading" />
+                <CircularProgress size="20px" data-testid="create-objects-circular-loading" />
               ) : (
                 <PublishIcon />
               )