[2108] WIP Improve actor creation tool

Bug: #2108
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

Author: gcoutable

CHANGELOG.adoc

@@ -28,6 +28,8 @@ As a result, the following GraphQL mutations have been removed `exposeRequiremen
 
 === Improvements
 
+- https://github.com/eclipse-syson/syson/issues/2108[#2108] [diagrams] Leverage the latest change of the selection dialog to allow creating an actor without specializing an existing element.
+
 === New features
 
 - https://github.com/eclipse-syson/syson/issues/1979[#1979] [diagrams] Add tools to create timeslices and snapshots, available on `OccurrenceUsage`, `ItemUsage`, and `PartUsage` graphical nodes.

backend/application/syson-application/src/test/java/org/eclipse/syson/application/controllers/diagrams/general/view/GVSubNodeAnalysisCreationTests.java

@@ -58,6 +58,7 @@
 import org.eclipse.syson.sysml.Element;
 import org.eclipse.syson.sysml.PartUsage;
 import org.eclipse.syson.sysml.ReferenceUsage;
+import org.eclipse.syson.sysml.Specialization;
 import org.eclipse.syson.sysml.Subsetting;
 import org.eclipse.syson.sysml.SysmlPackage;
 import org.eclipse.syson.sysml.Type;
@@ -525,6 +526,18 @@ public void createNewActorWithFeatureTypingInUseCaseUsage() {
         this.createActorWithFeatureTypingInCaseUsage(SysmlPackage.eINSTANCE.getUseCaseUsage(), GeneralViewWithTopNodesTestProjectData.SemanticIds.USE_CASE_USAGE_ID, USE_CASE);
     }
 
+    @GivenSysONServer({ GeneralViewWithTopNodesTestProjectData.SCRIPT_PATH })
+    @Test
+    public void createNewActorWithoutSpecializationInCaseUsage() {
+        this.createActorWithoutSpecializationInCaseUsage(SysmlPackage.eINSTANCE.getCaseUsage(), GeneralViewWithTopNodesTestProjectData.SemanticIds.CASE_USAGE_ID, CASE);
+    }
+
+    @GivenSysONServer({ GeneralViewWithTopNodesTestProjectData.SCRIPT_PATH })
+    @Test
+    public void createNewActorWithoutSpecializationInUseCaseUsage() {
+        this.createActorWithoutSpecializationInCaseUsage(SysmlPackage.eINSTANCE.getUseCaseUsage(), GeneralViewWithTopNodesTestProjectData.SemanticIds.USE_CASE_USAGE_ID, USE_CASE);
+    }
+
     private void createSubjectWithSubsettingInCaseUsage(EClass caseUsageSubclass, String targetObjectId, String parentLabel) {
         var flux = this.givenSubscriptionToDiagram();
 
@@ -539,7 +552,7 @@ private void createSubjectWithSubsettingInCaseUsage(EClass caseUsageSubclass, St
         String creationToolName = "New Subject";
         EReference containmentReference = SysmlPackage.eINSTANCE.getCaseUsage_SubjectParameter();
         List<ToolVariable> variables = new ArrayList<>();
-        String existingPartId = "2c5fe5a5-18fe-40f4-ab66-a2d91ab7df6a";
+        String existingPartId = GeneralViewWithTopNodesTestProjectData.SemanticIds.PART_USAGE_ID;
         variables.add(new ToolVariable("selectedObject", existingPartId, ToolVariableType.OBJECT_ID));
 
         Runnable createNodeRunnable = this.creationTestsService.createNode(diagramDescriptionIdProvider, diagram, caseUsageSubclass, targetObjectId, creationToolName, variables);
@@ -672,11 +685,9 @@ private void createActorWithSubsettingInCaseUsage(EClass caseUsageSubclass, Stri
         EClass childEClass = SysmlPackage.eINSTANCE.getPartUsage();
         String creationToolName = "New Actor";
         EReference containmentReference = SysmlPackage.eINSTANCE.getCaseUsage_ActorParameter();
-        List<ToolVariable> variables = new ArrayList<>();
-        String existingPartId = "2c5fe5a5-18fe-40f4-ab66-a2d91ab7df6a";
-        variables.add(new ToolVariable("selectedObject", existingPartId, ToolVariableType.OBJECT_ID));
+        String existingPartId = GeneralViewWithTopNodesTestProjectData.SemanticIds.PART_USAGE_ID;
 
-        Runnable createNodeRunnable = this.creationTestsService.createNode(diagramDescriptionIdProvider, diagram, caseUsageSubclass, targetObjectId, creationToolName, variables);
+        Runnable createNodeRunnable = this.creationTestsService.createNodeWithSelectionDialogWithSingleSelection(diagramDescriptionIdProvider, diagram, caseUsageSubclass, targetObjectId, creationToolName, existingPartId);
 
         Consumer<Object> diagramCheck = assertRefreshedDiagramThat(newDiagram -> {
             var initialDiagram = diagram.get();
@@ -726,11 +737,9 @@ private void createActorWithFeatureTypingInCaseUsage(EClass caseUsageSubclass, S
         EClass childEClass = SysmlPackage.eINSTANCE.getPartUsage();
         String creationToolName = "New Actor";
         EReference containmentReference = SysmlPackage.eINSTANCE.getCaseUsage_ActorParameter();
-        List<ToolVariable> variables = new ArrayList<>();
         String existingPartDefId = GeneralViewWithTopNodesTestProjectData.SemanticIds.PART_DEFINITION_ID;
-        variables.add(new ToolVariable("selectedObject", existingPartDefId, ToolVariableType.OBJECT_ID));
 
-        Runnable createNodeRunnable = this.creationTestsService.createNode(diagramDescriptionIdProvider, diagram, caseUsageSubclass, targetObjectId, creationToolName, variables);
+        Runnable createNodeRunnable = this.creationTestsService.createNodeWithSelectionDialogWithSingleSelection(diagramDescriptionIdProvider, diagram, caseUsageSubclass, targetObjectId, creationToolName, existingPartDefId);
 
         Consumer<Object> diagramCheck = assertRefreshedDiagramThat(newDiagram -> {
             var initialDiagram = diagram.get();
@@ -766,4 +775,57 @@ private void createActorWithFeatureTypingInCaseUsage(EClass caseUsageSubclass, S
                 .thenCancel()
                 .verify(Duration.ofSeconds(10));
     }
+
+    private void createActorWithoutSpecializationInCaseUsage(EClass caseUsageSubclass, String targetObjectId, String parentLabel) {
+        var flux = this.givenSubscriptionToDiagram();
+
+        AtomicReference<Diagram> diagram = new AtomicReference<>();
+        Consumer<Object> initialDiagramContentConsumer = assertRefreshedDiagramThat(diagram::set);
+
+        var diagramDescription = this.givenDiagramDescription.getDiagramDescription(GeneralViewWithTopNodesTestProjectData.EDITING_CONTEXT_ID,
+                SysONRepresentationDescriptionIdentifiers.GENERAL_VIEW_DIAGRAM_DESCRIPTION_ID);
+        var diagramDescriptionIdProvider = new DiagramDescriptionIdProvider(diagramDescription, this.diagramIdProvider);
+
+        EClass childEClass = SysmlPackage.eINSTANCE.getPartUsage();
+        String creationToolName = "New Actor";
+        EReference containmentReference = SysmlPackage.eINSTANCE.getCaseUsage_ActorParameter();
+
+        Runnable createNodeRunnable = this.creationTestsService.createNodeWithSelectionDialogWithoutSelectionProvided(diagramDescriptionIdProvider, diagram, caseUsageSubclass, targetObjectId, creationToolName);
+
+        Consumer<Object> diagramCheck = assertRefreshedDiagramThat(newDiagram -> {
+            var initialDiagram = diagram.get();
+            int createdNodesExpectedCount = 1;
+            new CheckDiagramElementCount(this.diagramComparator)
+                    .hasNewNodeCount(createdNodesExpectedCount)
+                    .hasNewEdgeCount(1)
+                    .check(initialDiagram, newDiagram, true);
+        });
+
+        ISemanticChecker semanticChecker = (editingContext) -> {
+            Object semanticRootObject = this.objectSearchService.getObject(editingContext, GeneralViewWithTopNodesTestProjectData.SemanticIds.PACKAGE_1_ID).orElse(null);
+            assertThat(semanticRootObject).isInstanceOf(Element.class);
+            Element semanticRootElement = (Element) semanticRootObject;
+            Optional<PartUsage> optActor = EMFUtils.allContainedObjectOfType(semanticRootElement, PartUsage.class)
+                    .filter(element -> Objects.equals(element.getName(), "actor1"))
+                    .findFirst();
+            assertThat(optActor).isPresent();
+            var actor = optActor.get();
+            assertThat(actor.getOwnedSpecialization()).allMatch(Specialization::isIsImplied);
+            EList<Type> types = actor.getType();
+            assertThat(types)
+                    .isNotEmpty()
+                    .allMatch(Element::isIsLibraryElement);
+        };
+        Runnable semanticCheck = this.semanticCheckerService.checkEditingContext(this.semanticCheckerService.getElementInParentSemanticChecker(parentLabel, containmentReference, childEClass));
+        Runnable semanticCheck2 = this.semanticCheckerService.checkEditingContext(semanticChecker);
+
+        StepVerifier.create(flux)
+                .consumeNextWith(initialDiagramContentConsumer)
+                .then(createNodeRunnable)
+                .consumeNextWith(diagramCheck)
+                .then(semanticCheck)
+                .then(semanticCheck2)
+                .thenCancel()
+                .verify(Duration.ofSeconds(10));
+    }
 }