[2058] Fix error when importing SysML snippets referencing unknown units

Bug: #2058
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>

Author: pcdavid

CHANGELOG.adoc

@@ -98,6 +98,7 @@ Now the _end_ keyword is not displayed anymore in the label of these graphical n
 - https://github.com/eclipse-syson/syson/issues/2054[#2054] [diagrams] Fix an error when invoking the tools _New Start Action_ or _New Done Action_ from inside a package named `Actions`.
 - https://github.com/eclipse-syson/syson/issues/2057[#2057] [diagrams] Fix the support for removing the multiplicity using the direct edit.
 - https://github.com/eclipse-syson/syson/issues/1938[#1938] [diagrams] Fix an issue where the _New Flow (flow)_ tool between two parameters was broken.
+- https://github.com/eclipse-syson/syson/issues/2058[#2058] [diagrams] Fix error when importing SysML snippets referencing unknown units which could make the resluting model inconsistent
 
 === Improvements
 

backend/application/syson-application/src/test/java/org/eclipse/syson/application/imports/ImportSysMLModelTest.java

@@ -27,6 +27,7 @@
 
 import org.eclipse.emf.common.notify.Notifier;
 import org.eclipse.emf.common.util.EList;
+import org.eclipse.emf.ecore.InternalEObject;
 import org.eclipse.sirius.components.core.api.IEditingContext;
 import org.eclipse.sirius.components.core.api.IEditingContextSearchService;
 import org.eclipse.sirius.components.core.api.IPayload;
@@ -1283,6 +1284,27 @@ public void checkDoSendPayloadParameterResolution() throws IOException {
         }).check(input);
     }
 
+    @DisplayName("Given an attribute valued with an unknown unit, WHEN importing the model, THEN then no unresolvable proxies are left")
+    @Test
+    public void referenceToUnknownUnit() throws IOException {
+        var input = """
+                part p {
+                    attribute a = 42 [W]
+                }
+                """;
+        this.checker.checkImportedModel(resource -> {
+            var iter = resource.getAllContents();
+            while (iter.hasNext()) {
+                var current = iter.next();
+                for (var target : current.eCrossReferences()) {
+                    assertThat(target).isNotNull();
+                    assertThat(((InternalEObject) target).eProxyURI()).isNull();
+                    assertThat(target.eIsProxy()).isFalse();
+                }
+            }
+        }).check(input);
+    }
+
     private void assertOperatorExpressionGuard(TransitionUsage t1, String expectedOperator, Class<?> expectedFirstParameterType, Class<?> expectedSecondParameterType) {
         EList<Expression> guardExpression1 = t1.getGuardExpression();
         assertThat(guardExpression1).hasSize(1);

backend/application/syson-sysml-import/src/main/java/org/eclipse/syson/sysml/parser/AstTreeParser.java

@@ -200,7 +200,7 @@ public void resolveAllReference(List<ProxiedReference> unresolvedReferences) {
                 "Non qualified proxy resolution phase", unresolvedAfterRedefinition);
 
         if (!unresolvedProxiesAfterUnqualified.isEmpty()) {
-            this.handleUnresolvableProxies(unresolvedAfterRedefinition);
+            this.handleUnresolvableProxies(unresolvedProxiesAfterUnqualified);
         }
     }
 

doc/content/modules/user-manual/pages/release-notes/2026.3.0.adoc

@@ -103,6 +103,7 @@ package Test {
 ** Fix the export of `LiteralString` with backslash characters.
 ** Fix textual import of `LiteralString` containing escaped backslash. In the following example `attribute a1 = "A \\ B";`, the value of "a1" is now "A \ B".
 The previous implementation was importing the value "A \\ B".
+** Fix error when importing SysML snippets referencing unknown units which could make the resluting model inconsistent
 
 * In _Explorer_ view: