fix: ObjectCloner.clone may return original object (#971)

sebthom · web-flow · commit a559e95a3782 · 2025-11-26T19:45:52.000+01:00
diff --git a/org.eclipse.tm4e.core/src/main/java/org/eclipse/tm4e/core/internal/utils/ObjectCloner.java b/org.eclipse.tm4e.core/src/main/java/org/eclipse/tm4e/core/internal/utils/ObjectCloner.java
@@ -79,7 +79,7 @@ public final class ObjectCloner {
 
 		final var shallowClone = shallowClone(obj, () -> obj);
 		clones.put(obj, shallowClone);
-		return obj;
+		return shallowClone;
 	}
 
 	private static @Nullable <@Nullable T> T deepCloneNullable(final T obj, final Map<Object, @Nullable Object> clones) {

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ public final class ObjectCloner {`
`79`	`79`
`80`	`80`	`final var shallowClone = shallowClone(obj, () -> obj);`
`81`	`81`	`clones.put(obj, shallowClone);`
`82`		`- return obj;`
	`82`	`+ return shallowClone;`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`private static @Nullable <@Nullable T> T deepCloneNullable(final T obj, final Map<Object, @Nullable Object> clones) {`