perf: avoid creating of unnecessary new list if changedRange is empty

sebthom · sebthom · commit ba5633f5ef96 · 2025-09-04T13:49:35.000+02:00
diff --git a/org.eclipse.tm4e.core/src/main/java/org/eclipse/tm4e/core/model/TMModel.java b/org.eclipse.tm4e.core/src/main/java/org/eclipse/tm4e/core/model/TMModel.java
@@ -279,8 +279,10 @@ private void revalidateTokens() {
 					if (DEBUG_LOGGING) {
 						logDebug("(%d) >> changedRanges: %s", startLineNumber, changedRanges);
 					}
-					listeners.dispatchEvent(changedRanges, TMModel.this);
-					changedRanges = new ArrayList<>();
+					if (!changedRanges.isEmpty()) {
+						listeners.dispatchEvent(changedRanges, TMModel.this);
+						changedRanges = new ArrayList<>();
+					}
 					prevRange = null;
 					startNanoTime = System.nanoTime();
 				}

Original file line number	Diff line number	Diff line change
`@@ -279,8 +279,10 @@ private void revalidateTokens() {`
`279`	`279`	`if (DEBUG_LOGGING) {`
`280`	`280`	`logDebug("(%d) >> changedRanges: %s", startLineNumber, changedRanges);`
`281`	`281`	`}`
`282`		`- listeners.dispatchEvent(changedRanges, TMModel.this);`
`283`		`- changedRanges = new ArrayList<>();`
	`282`	`+ if (!changedRanges.isEmpty()) {`
	`283`	`+ listeners.dispatchEvent(changedRanges, TMModel.this);`
	`284`	`+ changedRanges = new ArrayList<>();`
	`285`	`+ }`
`284`	`286`	`prevRange = null;`
`285`	`287`	`startNanoTime = System.nanoTime();`
`286`	`288`	`}`