|
| 1 | +<!--- |
| 2 | +Provide Title above, ensure it summarizes the work in the PR. Example PR titles templates: |
| 3 | +* "feature/ (or build/): describe new functionality" |
| 4 | +* "hotfix/: describe issue fix for immediate release" |
| 5 | +* "bugfix/ (or fix/): describe issue fix, not necessary for immediate release" |
| 6 | +* "docs/: adding or updating documentation" |
| 7 | +--> |
| 8 | + |
| 9 | +## Description & motivation |
| 10 | +<!--- |
| 11 | +High level description your PR, and why you're making it. Is this linked to slack thread, Monday board, open |
| 12 | +issue, a continuation to a previous PR? Link it here if relevant (use the "#" symbol for issues/PRs). |
| 13 | +--> |
| 14 | + |
| 15 | +## Breaking changes introduced by this PR: |
| 16 | +<!--- |
| 17 | +Describe any breaking changes that are introduced. Take a wide approach to what might be 'breaking'. One example of a 'hidden' breaking change could be adding a new column. For most applications, this will not cause error, but if someone has configured a downstream query that references this column name from elsewhere, their query could break. |
| 18 | +
|
| 19 | +Make sure to include these breaking changes in the CHANGELOG.md |
| 20 | +--> |
| 21 | + |
| 22 | +## PR Merge Priority: |
| 23 | +<!--- |
| 24 | +This checklist helps the reviewers understand the level of priority for merging this PR. |
| 25 | +A loose description of merging priority levels is: |
| 26 | +Low: A week or more. |
| 27 | +Medium: Within 3 days or less. |
| 28 | +High: As soon as possible. |
| 29 | +--> |
| 30 | +- [ ] Low |
| 31 | +- [ ] Medium |
| 32 | +- [ ] High |
| 33 | + |
| 34 | +<!--- |
| 35 | +If High Priority, explain why as a comment below. |
| 36 | +--> |
| 37 | + |
| 38 | +## Changes to existing files: |
| 39 | +<!--- |
| 40 | +Include this section if you are changing any existing files or creating breaking changes to existing files. Label the model name and describe the logic behind the changes made, try to be very descriptive here. For example: |
| 41 | +- `stg_model` : Describe any changes made to `stg_model` and why the changes where made. |
| 42 | +- `src_staging` : Describe any changes made to `src_staging` and why the changes where made. |
| 43 | +--> |
| 44 | + |
| 45 | +## New files created: |
| 46 | +<!--- |
| 47 | +Include this section if you are creating any new files. Label the model name and describe the logic behind the changes made, try to be very descriptive here. For example: |
| 48 | +- `stg_new_model` : Describe the purpose of `stg_new_model` and the logic behind creating the model. |
| 49 | +- `src_new_staging` : Describe the purpose of `src_new_staging`. |
| 50 | +--> |
| 51 | + |
| 52 | +## Tests and QC done: |
| 53 | +<!--- |
| 54 | +Describe any process that confirms that the files do what is expected, include screenshots if relevant. For example: |
| 55 | +- Analyst replication confirmed that updates to `stg_model` new counts were correct. |
| 56 | +- Executed a dbt project run and ensured it was successful. |
| 57 | +--> |
| 58 | + |
| 59 | +## edu_edfi_source PR Review Checklist: |
| 60 | +Make sure the following have been completed before approving this PR: |
| 61 | +- [ ] Description of changes has been added to Unreleased section of [CHANGELOG.md](/CHANGELOG.md). Add under `## New Features` for features, etc. |
| 62 | +- [ ] Code has been tested/checked for Databricks and Snowflake compatibility - EA engineers see Databricks checklist [here](https://edanalytics.slite.com/app/docs/LRjXFxVRAWA5ST) |
| 63 | +- [ ] Reviewer confirms the grain of all tables are unchanged, OR any changes are expected, communicated, and this PR is flagged as a breaking change (not for patch release) |
| 64 | + |
| 65 | +<!---## Future ToDos & Questions:--> |
| 66 | +<!--- |
| 67 | +[Optional] Include any future steps and questions related to this PR. |
| 68 | +--> |
0 commit comments