Skip to content

Commit d6224a5

Browse files
Fix/dbt test updates (#153)
* updated k_survey_section col list. Changed the order of the columns to match the order listed in survey sections and updated surveySectionTitle and changed from snake case to camel case * during the course of solving one bug, Jules discovered a bug with the k_survey_section_response variable. It was missing survey_response_id * updated changelog with macro and model updates
1 parent d028645 commit d6224a5

3 files changed

Lines changed: 6 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
# Unreleased
2+
- Updated `gen_skey.sql` macro. Changed the order of `k_survey_section` column list. Changed survey_section_title from snake case to camel case.
3+
- Corrected `stg_ef3__survey_section_responses.sql` model `k_survey_section_response` variable. previously missing `survey_response_id` variable.
24
## New features
35
## Under the hood
46
## Fixes

macros/gen_skey.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@
229229

230230
'k_survey_section': {
231231
'reference_name': 'survey_section_reference',
232-
'col_list': ['namespace', 'surveyIdentifier', 'survey_section_title'],
232+
'col_list': ['surveyIdentifier', 'namespace', 'surveySectionTitle'],
233233
'annualize': True
234234
},
235235

models/staging/edfi_3/stage/stg_ef3__survey_section_responses.sql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@ keyed as (
88
'api_year',
99
'lower(survey_id)',
1010
'lower(namespace)',
11-
'lower(survey_section_title)']
11+
'lower(survey_section_title)',
12+
'lower(survey_response_id)'
13+
]
1214
) }} as k_survey_section_response,
1315
{{ gen_skey('k_survey_response') }},
1416
{{ gen_skey('k_survey_section') }},

0 commit comments

Comments
 (0)