updates per review from John

Author: Tom Reitz

README.md

@@ -145,8 +145,6 @@ validate:
     - references # checks that references resolve, either locally or in the remote API
   # or
   # methods: "*"
-  # or
-  # methods: ALL
 ```
 Default `validate`.`methods` are `["schema", "descriptors", "uniqueness"]` (not `references`; see below). In addition to the above methods, `lighteam validate` will also (first) check that each payload is valid JSON.
 

lightbeam/validate.py

@@ -34,7 +34,7 @@ def __init__(self, lightbeam=None):
     def validate(self):
         self.lightbeam.api.load_swagger_docs()
         validation_methods = self.lightbeam.config.get("validate",{}).get("methods",self.DEFAULT_VALIDATION_METHODS)
-        if type(validation_methods)==str and (validation_methods=="*" or validation_methods.lower()=='all'):
+        if type(validation_methods)==str and validation_methods=="*":
             validation_methods = self.DEFAULT_VALIDATION_METHODS
             validation_methods.append("references")
         self.logger.info(f"validating by methods {validation_methods}...")
@@ -58,7 +58,7 @@ def validate(self):
                 # might resolve references from within payloads of this endpoint.
                 # We assume that the data fits in memory; the largest Ed-Fi endpoints
                 # (studentSectionAssociations, studentSchoolAttendanceEvents, etc.) contain references
-                # to comparatively datasets (sections, schools, students).
+                # to comparatively small datasets (sections, schools, students).
                 self.build_local_reference_cache(endpoint)
             asyncio.run(self.validate_endpoint(endpoint))
 
@@ -372,7 +372,6 @@ def get_cache_key(payload):
 
     def remote_reference_exists(self, endpoint, params):
         # check cache:
-        if endpoint=='students' and 'studentUniqueId' in params.keys(): return True
         if endpoint not in self.remote_reference_cache.keys():
             self.remote_reference_cache[endpoint] = []
         cache_key = self.get_cache_key(params)