fix: use insertFinalNewLine command (#428)

Author: SunsetTechuila

src/test/suite/index.test.ts

@@ -285,24 +285,24 @@ suite('EditorConfig extension', function () {
 		)
 	})
 
-	// test('keep selection on format', async () => {
-	// 	await withSetting('insert_final_newline', 'true', {
-	// 		fileName: 'test-selection',
-	// 	}).saveText('foobar')
-	// 	assert(window.activeTextEditor, 'no active editor')
+	test('keep selection on format', async () => {
+		await withSetting('insert_final_newline', 'true', {
+			fileName: 'test-selection',
+		}).saveText('foobar')
+		assert(window.activeTextEditor, 'no active editor')
 
-	// 	// Before saving, the selection is on line 0. This should remain unchanged.
-	// 	assert.strictEqual(
-	// 		window.activeTextEditor.selection.start.line,
-	// 		0,
-	// 		'editor selection start line changed',
-	// 	)
-	// 	assert.strictEqual(
-	// 		window.activeTextEditor.selection.end.line,
-	// 		0,
-	// 		'editor selection end line changed',
-	// 	)
-	// })
+		// Before saving, the selection is on line 0. This should remain unchanged.
+		assert.strictEqual(
+			window.activeTextEditor.selection.start.line,
+			0,
+			'editor selection start line changed',
+		)
+		assert.strictEqual(
+			window.activeTextEditor.selection.end.line,
+			0,
+			'editor selection end line changed',
+		)
+	})
 })
 
 function withSetting(

src/transformations/InsertFinalNewline.ts

@@ -1,5 +1,11 @@
 import { KnownProps } from 'editorconfig'
-import { Position, TextDocument, TextEdit } from 'vscode'
+import {
+	commands,
+	Position,
+	TextDocument,
+	TextEdit,
+	window,
+} from 'vscode'
 
 import { PreSaveTransformation } from './PreSaveTransformation'
 
@@ -24,6 +30,14 @@ export class InsertFinalNewline extends PreSaveTransformation {
 			return { edits: [] }
 		}
 
+		if (window.activeTextEditor && window.activeTextEditor.document === doc) {
+			commands.executeCommand('editor.action.insertFinalNewLine')
+			return {
+				edits: [],
+				message: 'editor.action.insertFinalNewLine',
+			}
+		}
+
 		const position = new Position(lastLine.lineNumber, lastLine.text.length)
 
 		const eol = (editorconfigProperties.end_of_line ?? 'lf').toUpperCase()