better service method names

Author: krawaller

src/services/battleservice.ts

@@ -23,7 +23,7 @@ export class BattleService {
   battleInfoForUser(id): Observable<CombatantInfo>{
     if (!this.cache[id]){
       let user$ = this.githubService.getUser(id);
-      let repo$ = this.githubService.getRepoListPages(id);
+      let repo$ = this.githubService.getRepos(id);
       return forkJoin(user$, repo$).pipe(map( ([user,list]) => {
         return ( this.cache[id] = ({id,user,repos:this.digestRepoList(list)}) );
       }));

src/services/githubservice.ts

@@ -23,7 +23,7 @@ export class GithubService {
     return this.http.get<GithubUserFullInfo>(this.urls.urlToUser(id))
   }
   private getRepoListSinglePage(id,page=1) {
-    return this.http.get<GithubRepo[]>(this.urls.urlToUserRepoListPage(id, page), { observe: 'response' }).pipe(
+    return this.http.get<GithubRepo[]>(this.urls.urlToRepoList(id, page), { observe: 'response' }).pipe(
       map( (res) => ({
         repos: res.body,
         pageNumber: page,
@@ -43,8 +43,8 @@ export class GithubService {
       share()
     );
   }
-  getRepoListPages(id){
-    let page$ = this.getRepoListPageStream(id);
+  getRepos(userId){
+    let page$ = this.getRepoListPageStream(userId);
     let all$ = page$.pipe(
       map(val=>val.repos),
       scan((acc, val)=> (acc||[]).concat(val))

src/services/urlservice.ts

@@ -15,7 +15,7 @@ const baseUrl = 'https://api.github.com/';
 @Injectable()
 export class UrlService {
   constructor(private authService: AuthService){}
-  urlToUserRepoListPage(id, page=1) {
+  urlToRepoList(id, page=1) {
     return baseUrl + 'users/' + id + '/repos?per_page=100&page=' + page + '&access_token=' + this.authService.authState.token;
   }
   urlToUser(id) {

src/specs/component.combatantdetail.spec.ts

@@ -16,7 +16,7 @@ const testModuleConfig = {
   declarations: [CombatantDetailComponent],
 }
 
-// ------------ Moch input data -------------
+// ------------ Mock input data -------------
 
 type RecursivePartial<T> = { [P in keyof T]?: RecursivePartial<T[P]>; }; // https://stackoverflow.com/a/47914631
 import { CombatantInfo } from '../types';