Skip to content

Commit a6e34c1

Browse files
committed
fix: update frontend-app-learning port from 2000 to 2010 to resolve Codespaces conflict
1 parent 34affdf commit a6e34c1

6 files changed

Lines changed: 10 additions & 7 deletions

File tree

docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1103,7 +1103,7 @@ services:
11031103
aliases:
11041104
- edx.devstack.frontend-app-learning
11051105
ports:
1106-
- "2010:2000"
1106+
- "2010:2000" # avoid Codespaces port 2000 conflict
11071107
depends_on:
11081108
- lms
11091109

docs/service_list.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,15 @@ Instead of a service name or list, you can also run commands like ``make dev.pro
7575
+------------------------------------+-------------------------------------+----------------+--------------+
7676
| `enterprise-subsidy`_ | http://localhost:18280 | Python/Django | Extra |
7777
+------------------------------------+-------------------------------------+----------------+--------------+
78+
| **Reserved for Codespace** | http://localhost:2000 | **Codespace** | Default |
79+
+------------------------------------+-------------------------------------+----------------+--------------+
7880

7981
Some common service combinations include:
8082

8183
* ``lms``: LMS, along with dependencies ``forum``, ``discovery``, ``Authn`` and some databases
8284
* ``ecommerce``: Ecommerce, but also LMS as a dependency (for auth)
8385
* ``cms+credentials``: Services can be combined to affect both at once
86+
* **Reserved for Codespace**: The port `2000` is being used for github Codespace service & reserverd for Codespace use only.
8487

8588
.. _credentials: https://github.com/openedx/credentials
8689
.. _discovery: https://github.com/openedx/course-discovery

py_configuration_files/course_discovery.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
'http://localhost:1991', # frontend-app-admin-portal
1919
'http://localhost:18400', # frontend-app-publisher
2020
'http://localhost:18450', # frontend-app-support-tools
21-
'http://localhost:2010', # frontend-app-learning
21+
'http://localhost:2010', # frontend-app-learning (port changed from 2000 to 2010, due to conflict in codepsace)
2222
)
2323

2424
ELASTICSEARCH_DSL['default']['hosts'] = 'edx.devstack.elasticsearch710:9200'

py_configuration_files/ecommerce.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
'http://localhost:1996',
5656
'http://localhost:1997', # Account MFE
5757
'http://localhost:1998',
58-
'http://localhost:2010', # Learning MFE
58+
'http://localhost:2010', # Learning MFE (port changed from 2000 to 2010, due to conflict in codepsace)
5959
'http://localhost:8734', # Enterprise Learner Portal MFE
6060
)
6161
CORS_ALLOW_HEADERS = corsheaders_default_headers + (

py_configuration_files/enterprise_subsidy.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
LMS_URL = 'http://edx.devstack.lms:18000'
7676
ENTERPRISE_CATALOG_URL = 'http://edx.devstack.enterprise-catalog:18160'
7777
ENTERPRISE_SUBSIDY_URL = 'http://localhost:18280'
78-
FRONTEND_APP_LEARNING_URL = 'http://localhost:2010' # Learning MFE
78+
FRONTEND_APP_LEARNING_URL = 'http://localhost:2010' # Learning MFE (port changed from 2000 to 2010, due to conflict in codepsace)
7979

8080
# Kafka Settings
8181
# "Standard" Kafka settings as defined in https://github.com/openedx/event-bus-kafka/tree/main

py_configuration_files/lms.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ def should_show_debug_toolbar(request): # lint-amnesty, pylint: disable=missing
304304
'localhost:1997', # frontend-app-account
305305
'localhost:1976', # frontend-app-program-console
306306
'localhost:1994', # frontend-app-gradebook
307-
'localhost:2010', # frontend-app-learning
307+
'localhost:2010', # frontend-app-learning (port changed from 2000 to 2010, due to conflict in codepsace)
308308
'localhost:2001', # frontend-app-course-authoring
309309
'localhost:3001', # frontend-app-library-authoring
310310
'localhost:18400', # frontend-app-publisher
@@ -382,7 +382,7 @@ def should_show_debug_toolbar(request): # lint-amnesty, pylint: disable=missing
382382
EDXNOTES_CLIENT_NAME = 'edx_notes_api-backend-service'
383383

384384
############## Settings for Microfrontends #########################
385-
LEARNING_MICROFRONTEND_URL = 'http://localhost:2010'
385+
LEARNING_MICROFRONTEND_URL = 'http://localhost:2010' # (port changed from 2000 to 2010, due to conflict in codepsace)
386386
ACCOUNT_MICROFRONTEND_URL = 'http://localhost:1997'
387387
PROFILE_MICROFRONTEND_URL = 'http://localhost:1995'
388388
COMMUNICATIONS_MICROFRONTEND_URL = 'http://localhost:1984'
@@ -542,7 +542,7 @@ def should_show_debug_toolbar(request): # lint-amnesty, pylint: disable=missing
542542

543543
# MFEs that will call this service in devstack
544544
CSRF_TRUSTED_ORIGINS = [
545-
'http://localhost:2010', # frontend-app-learning
545+
'http://localhost:2010', # frontend-app-learning (port changed from 2000 to 2010, due to conflict in codepsace)
546546
'http://localhost:2001', # frontend-app-course-authoring
547547
'http://localhost:1997', # frontend-app-account
548548
'http://localhost:1995', # frontend-app-profile

0 commit comments

Comments
 (0)