Skip to content

Commit fa222b7

Browse files
committed
TPC CMV: adjust log severities, add additional logs
1 parent 75b765c commit fa222b7

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

Detectors/TPC/workflow/include/TPCWorkflow/TPCDistributeCMVSpec.h

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ class TPCDistributeCMVSpec : public o2::framework::Task
149149
// check which buffer to use for current incoming data
150150
const bool currentBuffer = (tf > mTFEnd[mBuffer]) ? !mBuffer : mBuffer;
151151
if (mTFStart[currentBuffer] > tf) {
152-
LOGP(detail, "All CRUs for current TF {} already received. Skipping this TF", tf);
152+
LOGP(info, "Current TF {} is older than start of currentBuffer {}. Skipping this TF", tf, mTFStart[currentBuffer]);
153153
return;
154154
}
155155

@@ -166,6 +166,7 @@ class TPCDistributeCMVSpec : public o2::framework::Task
166166
}
167167

168168
if (mProcessedCRU[currentBuffer][relTF] == mCRUs.size()) {
169+
LOGP(info, "All CRUs for current TF {} (relTF {}) already received. Skipping this TF", tf, relTF);
169170
return;
170171
}
171172

@@ -193,6 +194,7 @@ class TPCDistributeCMVSpec : public o2::framework::Task
193194
}
194195

195196
if (mProcessedCRUs[currentBuffer][relTF][cru]) {
197+
LOGP(warning, "CRU {} for current TF {} (relTF {}) already processed. Skipping ...", cru, tf, relTF);
196198
continue;
197199
}
198200
// count total number of processed CRUs for given TF
@@ -363,15 +365,15 @@ class TPCDistributeCMVSpec : public o2::framework::Task
363365

364366
// if the last buffer has a smaller time range than expected, flush its remaining uncompleted TFs
365367
if ((mTFStart[currentBuffer] > mTFStart[!currentBuffer]) && (relTF > mNTFsDataDrop)) {
366-
LOGP(warning, "Checking last buffer from {} to {}", mStartNTFsDataDrop[!currentBuffer], mProcessedCRU[!currentBuffer].size());
368+
LOGP(info, "Checking last buffer from relTF {} to {}", mStartNTFsDataDrop[!currentBuffer], mProcessedCRU[!currentBuffer].size());
367369
const unsigned int lastLane = (currentOutLane == 0) ? (mOutLanes - 1) : (currentOutLane - 1);
368370
checkMissingData(pc, !currentBuffer, mStartNTFsDataDrop[!currentBuffer], mProcessedCRU[!currentBuffer].size(), lastLane);
369-
LOGP(detail, "All empty TFs for TF {} for current buffer filled with dummy and sent. Clearing buffer", tf);
371+
LOGP(info, "All empty TFs of last buffer [{}, {}] filled with dummy and sent, triggered by data from TF {} (relTF {}). Clearing buffer", mTFStart[!currentBuffer], mTFEnd[!currentBuffer], tf, relTF);
370372
finishInterval(pc, lastLane, !currentBuffer, tf);
371373
}
372374

373375
const int tfEndCheck = std::clamp(static_cast<int>(relTF) - mNTFsDataDrop, 0, static_cast<int>(mProcessedCRU[currentBuffer].size()));
374-
LOGP(detail, "Checking current buffer from {} to {}", mStartNTFsDataDrop[currentBuffer], tfEndCheck);
376+
LOGP(detail, "Checking current buffer from relTF {} to {}", mStartNTFsDataDrop[currentBuffer], tfEndCheck);
375377
checkMissingData(pc, currentBuffer, mStartNTFsDataDrop[currentBuffer], tfEndCheck, currentOutLane);
376378
mStartNTFsDataDrop[currentBuffer] = tfEndCheck;
377379
}
@@ -381,7 +383,7 @@ class TPCDistributeCMVSpec : public o2::framework::Task
381383
{
382384
for (int iTF = startTF; iTF < endTF; ++iTF) {
383385
if (mProcessedCRU[currentBuffer][iTF] != mCRUs.size()) {
384-
LOGP(warning, "CRUs for lane {} rel. TF: {} curr TF {} are missing! Processed {} CRUs out of {}", outLane, iTF, mTFStart[currentBuffer] + static_cast<long>(iTF) * mNTFsBuffer, mProcessedCRU[currentBuffer][iTF], mCRUs.size());
386+
LOGP(warning, "CRUs for lane {} rel. TF: {} curr TF {} are missing! Processed {} CRUs out of {}", outLane, iTF, mTFStart[currentBuffer] + static_cast<long>(iTF) * mNTFsBuffer + mNTFsBuffer - 1, mProcessedCRU[currentBuffer][iTF], mCRUs.size());
385387
++mProcessedTFs[currentBuffer];
386388
mProcessedCRU[currentBuffer][iTF] = mCRUs.size();
387389

@@ -415,7 +417,7 @@ class TPCDistributeCMVSpec : public o2::framework::Task
415417
}
416418
}
417419

418-
LOGP(detail, "All TFs {} for current buffer received. Clearing buffer", tf);
420+
LOGP(info, "All TFs for {} buffer [{}, {}] received at data from TF {}. Clearing buffer", buffer == mBuffer ? "last" : "current", mTFStart[buffer], mTFEnd[buffer], tf);
419421
clearBuffer(buffer);
420422
mStartNTFsDataDrop[buffer] = 0;
421423
mSendOutputStartInfo[buffer] = true;

0 commit comments

Comments
 (0)