fix: fix downloadFile unit test

mdelapenya · mdelapenya · commit 12e71d39a25d · 2020-04-23T15:47:36.000+02:00
diff --git a/e2e/utils_test.go b/e2e/utils_test.go
@@ -2,6 +2,7 @@ package e2e
 
 import (
 	"os"
+	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -14,12 +15,13 @@ func TestDownloadFile(t *testing.T) {
 	if err != nil {
 		t.Fail()
 	}
+	defer os.Remove(configurationFilePath)
 
 	info, err := os.Stat(configurationFilePath)
 	if os.IsNotExist(err) {
 		t.Fail()
 	}
 
 	assert.False(t, info.IsDir())
-	assert.Equal(t, "metricbeat.yml", info.Name())
+	assert.True(t, strings.HasPrefix(info.Name(), "metricbeat.yml"))
 }

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@ package e2e`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"os"`
	`5`	`+ "strings"`
`5`	`6`	`"testing"`
`6`	`7`
`7`	`8`	`"github.com/stretchr/testify/assert"`
`@@ -14,12 +15,13 @@ func TestDownloadFile(t *testing.T) {`
`14`	`15`	`if err != nil {`
`15`	`16`	`t.Fail()`
`16`	`17`	`}`
	`18`	`+ defer os.Remove(configurationFilePath)`
`17`	`19`
`18`	`20`	`info, err := os.Stat(configurationFilePath)`
`19`	`21`	`if os.IsNotExist(err) {`
`20`	`22`	`t.Fail()`
`21`	`23`	`}`
`22`	`24`
`23`	`25`	`assert.False(t, info.IsDir())`
`24`		`- assert.Equal(t, "metricbeat.yml", info.Name())`
	`26`	`+ assert.True(t, strings.HasPrefix(info.Name(), "metricbeat.yml"))`
`25`	`27`	`}`