actions: run unit-tests and linting in GH actions (#3138)

Author: v1v

.ci/Jenkinsfile

@@ -52,7 +52,6 @@ pipeline {
     string(name: 'runTestsSuites', defaultValue: '', description: 'A comma-separated list of test suites to run (default: empty to run all test suites)')
     string(name: 'testMatrixFile', defaultValue: '.ci/.e2e-tests.yaml', description: 'The file with the test suite and scenarios to be tested.')
     booleanParam(name: "forceSkipGitChecks", defaultValue: false, description: "If it's needed to check for Git changes to filter by modified sources")
-    booleanParam(name: "forceSkipPresubmit", defaultValue: false, description: "If it's needed to execute the pre-submit tests: unit and precommit.")
     booleanParam(name: "notifyOnGreenBuilds", defaultValue: false, description: "If it's needed to notify to Slack with green builds.")
     string(name: 'SLACK_CHANNEL', defaultValue: 'observablt-bots', description: 'The Slack channel(s) where errors will be posted. For multiple channels, use a comma-separated list of channels')
     string(name: 'ELASTIC_AGENT_DOWNLOAD_URL', defaultValue: '', description: 'If present, it will override the download URL for the Elastic agent artifact. (I.e. https://snapshots.elastic.co/8.0.0-59098054/downloads/beats/elastic-agent/elastic-agent-8.0.0-SNAPSHOT-linux-x86_64.tar.gz')
@@ -85,7 +84,6 @@ pipeline {
         KIBANA_VERSION = "${params.KIBANA_VERSION.trim()}"
         STACK_VERSION = "${params.STACK_VERSION.trim()}"
         FORCE_SKIP_GIT_CHECKS = "${params.forceSkipGitChecks}"
-        FORCE_SKIP_PRESUBMIT = "${params.forceSkipPresubmit}"
         HELM_CHART_VERSION = "${params.HELM_CHART_VERSION.trim()}"
         HELM_VERSION = "${params.HELM_VERSION.trim()}"
         KIND_VERSION = "${params.KIND_VERSION.trim()}"
@@ -108,61 +106,6 @@ pipeline {
             checkSkipTests()
           }
         }
-        stage('Pre-Submit') {
-          when {
-            beforeAgent true
-            expression { return env.FORCE_SKIP_PRESUBMIT == "false" }
-          }
-          parallel {
-            stage('Sanity checks') {
-              agent { label 'ubuntu-20.04 && immutable && docker' }
-              environment {
-                PATH = "${env.REAL_BASE_DIR}/bin:${env.PATH}"
-                GO111MODULE = 'auto'
-              }
-              options { skipDefaultCheckout() }
-              steps {
-                withGithubNotify(context: 'Sanity checks', tab: 'tests') {
-                  deleteDir()
-                  unstash 'source'
-                  withGoEnv(version: "${GO_VERSION}"){
-                    dir(BASE_DIR){
-                      retryWithSleep(retries: 2, seconds: 5, backoff: true){ sh script: '.ci/scripts/install-dependencies.sh', label: 'Install dependencies' }
-                      preCommit(commit: "${GIT_BASE_COMMIT}", junit: true)
-                    }
-                  }
-                }
-              }
-            }
-            stage('Unit Tests') {
-              options { skipDefaultCheckout() }
-              when {
-                beforeAgent true
-                anyOf {
-                  expression { return env.FORCE_SKIP_GIT_CHECKS == "true" }
-                  expression { return env.SKIP_TESTS == "false" }
-                }
-              }
-              steps {
-                withGithubNotify(context: 'Tests', tab: 'tests') {
-                  deleteDir()
-                  unstash 'source'
-                  withGoEnv(version: "${GO_VERSION}"){
-                    dir(BASE_DIR){
-                      sh script: '.ci/scripts/build-test.sh', label: 'Build and test'
-                    }
-                  }
-                }
-              }
-              post {
-                always {
-                  junit2otel(traceName: 'junit-unit-tests', allowEmptyResults: true, keepLongStdio: true, testResults: "${BASE_DIR}/outputs/TEST-unit-*.xml")
-                  archiveArtifacts allowEmptyArchive: true, artifacts: "${BASE_DIR}/outputs/TEST-unit-*.xml"
-                }
-              }
-            }
-          }
-        }
         stage('Build Docs') {
           options { skipDefaultCheckout() }
           when {
@@ -173,8 +116,6 @@ pipeline {
             }
           }
           steps {
-            deleteDir()
-            unstash 'source'
             dockerLogin(secret: "${DOCKER_ELASTIC_SECRET}", registry: "${DOCKER_REGISTRY}")
             dir("${BASE_DIR}/e2e") {
               sh(label: 'Build docs', script: 'make build-docs')
@@ -188,7 +129,6 @@ pipeline {
             }
           }
         }
-
         stage('Deploy Test Infra') {
           failFast true
           options { skipDefaultCheckout() }

.github/workflows/golangci-lint.yml

@@ -0,0 +1,29 @@
+name: golangci-lint
+on:
+  pull_request:
+
+permissions:
+  contents: read
+  pull-requests: read
+
+jobs:
+  golangci:
+    strategy:
+      matrix:
+        os: [ ubuntu-latest, windows-latest ]
+    name: lint
+    runs-on: ${{  matrix.os }}
+    steps:
+      - uses: actions/checkout@v3
+      - name: Fetch Go version from .go-version
+        run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
+      - uses: actions/setup-go@v3
+        with:
+          go-version: ${{ env.GO_VERSION }}
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v3
+        with:
+          version: v1.47.2
+          args: --timeout=30m --whole-files
+          # Optional: show only new issues if it's a pull request. The default value is `false`.
+          only-new-issues: true

.github/workflows/junit-test-reporter.yml

@@ -0,0 +1,23 @@
+---
+## Workflow to process the JUnit test results and add a report to the checks.
+name: Test Report
+on:
+  workflow_run:
+    workflows:
+      - pull-request
+    types:
+      - completed
+
+permissions:
+  contents: read
+
+jobs:
+  report:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: elastic/apm-pipeline-library/.github/actions/test-report@gh_actions
+        with:
+          artifact: test-results            # artifact name
+          name: JUnit Tests                 # Name of the check run which will be created
+          path: "**/*.xml"                   # Path to test results (inside artifact .zip)
+          reporter: java-junit              # Format of test results

.github/workflows/pull-request.yml

@@ -0,0 +1,50 @@
+---
+## Workflow to lint and test
+name: pull-request
+
+permissions:
+  contents: read
+
+on:
+  pull_request:
+  push:
+
+jobs:
+  pre-commit:
+    runs-on: ubuntu-latest
+    env:
+      JENKINS_URL: https://beats-ci.elastic.co/
+    steps:
+      - uses: actions/checkout@v3
+      - name: Fetch Go version from .go-version
+        run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
+      - uses: actions/setup-python@v3
+      - uses: actions/setup-go@v3
+        with:
+          go-version: ${{ env.GO_VERSION }}
+      - name: Install dependencies
+        run: |
+          go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.50.0
+          go install golang.org/x/lint/golint
+
+      - uses: pre-commit/action@v3.0.0
+
+  test:
+    name: Run Test
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Fetch Go version from .go-version
+        run: echo "GO_VERSION=$(cat .go-version)" >> $GITHUB_ENV
+      - uses: actions/setup-go@v3
+        with:
+          go-version: ${{ env.GO_VERSION }}
+          cache: true
+          cache-dependency-path: go.sum
+      - name: build
+        run: .ci/scripts/build-test.sh
+      - uses: actions/upload-artifact@v3  # upload test results
+        if: success() || failure()        # run this step even if previous step failed
+        with:
+          name: test-results
+          path: outputs/TEST-unit-*.xml

.go-version

@@ -1 +1 @@
-1.17
+1.18

.pre-commit-config.yaml

@@ -52,7 +52,6 @@ repos:
             (?x)^(
                 .*/?\.*.(tar.gz)
             )$
-    -   id: check-jjbb
     -   id: check-gherkin-lint
         args: [
             "--disable", "AvoidOutlineForSingleExample,TooClumsy,TooManyTags,TooLongStep,TooManyDifferentTags,TooManySteps,UseBackground",