createContactList using only post params

AUT-4110

Co-authored-by: Bence Kadar <bence.kadar@emarsys.com>

Author: szerintem

src/Suite/Api/ContactList.php

@@ -39,9 +39,13 @@ public function createContactList(
             $data['external_ids'] = $contactIds;
         }
 
+        if($businessAreaId) {
+            $data['business_area_id'] = $businessAreaId;
+        }
+
         try {
             return $this->apiClient->post(
-                $this->endPoints->createContactList($customerId, $businessAreaId), $data)['data']['id'];
+                $this->endPoints->createContactList($customerId), $data)['data']['id'];
         } catch (Error $error) {
             throw new RequestFailed('Could not create contact list: ' . $error->getMessage(), $error->getCode(), $error);
         }

src/Suite/Api/ContactListEndPoints.php

@@ -19,16 +19,14 @@ private function baseUrl(int $customerId)
         return "{$this->apiBaseUrl}/{$customerId}/contactlist";
     }
 
-    public function createContactList(int $customerId, string $businessAreaId = null)
+    public function createContactList(int $customerId)
     {
-        return $this->baseUrl($customerId)
-            . ($businessAreaId ? "/?business_area_id=$businessAreaId" : '');
+        return $this->baseUrl($customerId);
     }
 
-    public function contactLists(int $customerId, string $businessAreaId = null)
+    public function contactLists(int $customerId)
     {
-        return $this->baseUrl($customerId)
-            . ($businessAreaId ? "/?business_area_id=$businessAreaId" : '');
+        return $this->baseUrl($customerId);
     }
 
     public function addToContactList(int $customerId, int $contactListId)

test/unit/Suite/Api/ContactListTest.php

@@ -52,11 +52,12 @@ public function createContactList_CalledWithBusinessAreaId_PassesBusinessAreaId(
             ->expects($this->once())
             ->method('post')
             ->with(
-                "api_base_url/$this->customerId/contactlist/?business_area_id=$businessAreaId",
+                "api_base_url/$this->customerId/contactlist",
                 [
                     'name' => $this->listName,
                     'key_id' => 'id',
                     'external_ids' => $contactIds,
+                    'business_area_id' => $businessAreaId
                 ]
             )
             ->willReturn($this->apiSuccess(['id' => $this->contactListId]));
@@ -122,25 +123,6 @@ public function getContactLists_Perfect_Perfect(): void
         $this->assertEquals($contactLists, $returnedContactLists);
     }
 
-    /**
-     * @test
-     */
-    public function getContactLists_CalledWithBusinessAreaId_PassesBusinessAreaId(): void
-    {
-        $businessAreaId = 'HU';
-        $contactLists = [
-            $this->contactListData('id', 'contact list'),
-        ];
-
-        $this->apiClient
-            ->expects($this->once())
-            ->method('get')
-            ->with("api_base_url/$this->customerId/contactlist/?business_area_id=$businessAreaId")
-            ->willReturn($this->apiSuccess($contactLists));
-
-        $this->listService->getContactLists($this->customerId, $businessAreaId);
-    }
-
     /**
      * @test
      */