handle empty resultset from contact api

Author: Attila Dröszler

src/Suite/Api/Contact/Contact.php

@@ -36,7 +36,7 @@ public function getList(int $customerId, $keyId, array $keyValues, array $fields
         try
         {
             $response = $this->apiClient->post($this->endPoints->getData($customerId), $postData);
-            return $response['data']['result'];
+            return $response['data']['result'] ?: [];
         }
         catch (Error $ex)
         {

test/unit/Suite/Api/Contact/ContactTest.php

@@ -44,6 +44,18 @@ public function getData_Perfect_Perfect()
         $this->assertEquals($contacts, $responseData);
     }
 
+    /**
+     * @test
+     */
+    public function getData_ContactNotFound_EmptyArrayReturned()
+    {
+        $this->apiClient->expects($this->once())->method('post')
+            ->will($this->apiSuccess([]));
+
+        $responseData = $this->contact->getList($this->customerId, 'id', [1, 2], [3]);
+        $this->assertEquals([], $responseData);
+    }
+
     /**
      * @test
      */
@@ -60,16 +72,16 @@ public function get_ApiFailure_ExceptionThrown()
         $this->fail('No exception was thrown.');
     }
 
-    private function apiSuccess($data = [])
+    private function apiSuccess(array $data = [])
     {
         return $this->returnValue([
             'success' => true,
             'replyCode' => self::API_SUCCESS_CODE,
             'replyText' => self::API_SUCCESS_TEXT,
             'data' => [
                 'errors' => [],
-                'result' => $data
-            ]
+                'result' => $data ?: false,
+            ],
         ]);
     }