Commit 5c45cae
Robert Jackson
Revert "Bump semver from 6.3.0 to 7.0.0"
This reverts commit 1c62ef6.
**_tldr;_** `semver@7.x` _arguably_ includes breaking changes in a minor
release (from 7.0.0 to 7.1.0), and we cannot update to 7.x until
ember-cli-htmlbars drops Node 8 support.
At the time the `semver@7.0.0` version bump (from 1c62ef6) landed the
CHANGELOG.md for `semver@7.0.0` stated:
* Refactor module into separate files for better tree-shaking
* Drop support for very old node versions, use const/let, => functions,
and classes.
The verbiage here is obviously imprecise, and when merging (and
releasing) I misinterpretted "very old node versions" as being versions
older than Node 4.0.0 (in other words, versions that didn't support the
features stated immediately following). Unfortunately, semver changed
their `engines` version _after_ 7.0.0 was released (included in the
7.1.0 release) to only allow Node 10 or higher (see
[here](npm/node-semver@d61f828)).
Unfortunately, due to the way `yarn` works by default, this change in
`engines` is actually a breaking change for `yarn` users (unless they
specify the `--ignore-engines` flag).1 parent 4a69677 commit 5c45cae
2 files changed
Lines changed: 1 addition & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8441 | 8441 | | |
8442 | 8442 | | |
8443 | 8443 | | |
8444 | | - | |
8445 | | - | |
8446 | | - | |
8447 | | - | |
8448 | | - | |
8449 | 8444 | | |
8450 | 8445 | | |
8451 | 8446 | | |
| |||
0 commit comments