Skip to content

Commit 5d8f19b

Browse files
authored
Merge pull request #19 from engingulek/feature/update-view-kit
Feature/update view kit
2 parents 1b59923 + 8142e9e commit 5d8f19b

7 files changed

Lines changed: 35 additions & 7 deletions

File tree

ICTMDBHomeModule/HomePresenter.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ extension HomePresenter: ViewToPresenterHomeProtocol {
5454

5555
func viewDidLoad() {
5656
view?.setBackColorAble(color: "backColor")
57+
//TODO: move to Localizable
58+
view?.setNavigationTitle(title: "Home Page")
5759
interactor.loadPopularMovies()
5860
interactor.loadAiringMovies()
5961
}

ICTMDBHomeModule/HomeProtocols.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import UIKit
1313

1414
// MARK: - Typealias
1515
/// Combines UIViewAble and SegueAble protocols for convenience.
16-
typealias Ables = UIViewAble & SegueAble
16+
typealias Ables = UIViewAble & SegueAble & NavConUIAble
1717

1818
// MARK: - View → Presenter
1919
/// Protocol for communication from View to Presenter.

ICTMDBHomeModule/HomeViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,5 +135,5 @@ extension HomeViewController: @MainActor PresenterToViewHomeProtocol {
135135
// MARK: - Preview
136136
#Preview {
137137
let module = ICTMDBHomeModule()
138-
module.createHomeModule()
138+
UINavigationController(rootViewController: module.createHomeModule())
139139
}

ICTMDBHomeModuleTests/ICTMDBHomeModuleTests.swift

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,20 @@ struct ICTMDBHomeModuleTests {
4242
#expect(view.invokedSetBackColorAbleData == ["backColor"])
4343
}
4444

45+
46+
@Test("Set navigaiton title")
47+
func testNavigationTitle() {
48+
#expect(view.invokedSetNavigationTitle == false)
49+
#expect(view.invokedSetNavigationTitleCount == 0)
50+
51+
presenter.viewDidLoad()
52+
53+
#expect(view.invokedSetNavigationTitle == true)
54+
#expect(view.invokedSetNavigationTitleCount == 1)
55+
#expect(view.invokedSetNavigationTitleData.map(\.title) == ["Home Page"])
56+
57+
}
58+
4559
@Test("Check number of sections")
4660
func testNumberOfSections() {
4761
presenter.viewDidLoad()

ICTMDBHomeModuleTests/MockHomeViewController.swift

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import UIKit
1010
@testable import ICTMDBHomeModule
1111

1212
final class MockHomeViewController: PresenterToViewHomeProtocol {
13+
1314

1415
// MARK: - Mock Functions
1516

@@ -19,6 +20,17 @@ final class MockHomeViewController: PresenterToViewHomeProtocol {
1920
invokedRelaodCollectionView = true
2021
invokedRelaodCollectionViewCount += 1
2122
}
23+
24+
var invokedSetNavigationTitle = false
25+
var invokedSetNavigationTitleCount = 0
26+
var invokedSetNavigationTitleData: [(title: String,())] = []
27+
func setNavigationTitle(title: String) {
28+
invokedSetNavigationTitle = true
29+
invokedSetNavigationTitleCount += 1
30+
invokedSetNavigationTitleData.append((title: title, ()))
31+
32+
}
33+
2234

2335
var invokedSendError = false
2436
var invokedSendErrorCount = 0

Package.resolved

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Package.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ let package = Package(
1515
],
1616
dependencies: [
1717
.package(url: "https://github.com/SnapKit/SnapKit.git", from: "5.0.1"),
18-
.package(url: "https://github.com/engingulek/GenericCollectionViewKit",from:"0.0.1"),
18+
.package(url: "https://github.com/engingulek/GenericCollectionViewKit",from:"0.0.2"),
1919
.package(url: "https://github.com/engingulek/ICTMDBModularProtocols", from: "0.0.1"),
20-
.package(url: "https://github.com/engingulek/ICTMDBNetworkManagerKit", from: "0.0.1"),
21-
.package(url: "https://github.com/engingulek/ICTMDBViewKit", from: "0.0.1"),
20+
.package(url: "https://github.com/engingulek/ICTMDBNetworkManagerKit", from: "0.0.2"),
21+
.package(url: "https://github.com/engingulek/ICTMDBViewKit", from: "0.0.3"),
2222
.package(url: "https://github.com/engingulek/HPDependencyKit", from: "1.0.0"),
2323
],
2424
targets: [

0 commit comments

Comments
 (0)