From 72120a0aa52bb43001255aac8fb9fada59eef477 Mon Sep 17 00:00:00 2001 From: Desel72 <6442298+Desel72@users.noreply.github.com> Date: Tue, 12 May 2026 19:06:00 +0200 Subject: [PATCH] fix: fail incomplete pr content fetches --- packages/das/src/webhook/github-fetcher.service.ts | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/das/src/webhook/github-fetcher.service.ts b/packages/das/src/webhook/github-fetcher.service.ts index b902f83..2891a8b 100644 --- a/packages/das/src/webhook/github-fetcher.service.ts +++ b/packages/das/src/webhook/github-fetcher.service.ts @@ -380,10 +380,9 @@ export class GitHubFetcherService implements OnModuleInit { // 3. Fetch file contents in batches (base + head in one GraphQL call each) if (!pr.headSha) { - this.logger.warn( - `PR ${repoFullName}#${prNumber} has no head SHA — skipping content fetch`, + throw new Error( + `PR ${repoFullName}#${prNumber} has no head SHA; cannot fetch content`, ); - return; } // Prefer merge-base SHA (true common ancestor) over base SHA for @@ -507,10 +506,9 @@ export class GitHubFetcherService implements OnModuleInit { batchSize = newSize; // Retry same i with smaller batch } else { - this.logger.warn( - `GraphQL content batch failed at min size ${minBatchSize}: ${err}. Skipping batch.`, + throw new Error( + `GraphQL content batch failed at min size ${minBatchSize}: ${err}`, ); - i += batch.length; } } }