Skip to content

Commit 24b43d5

Browse files
committed
cleanup
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
1 parent 20f577e commit 24b43d5

3 files changed

Lines changed: 11 additions & 4 deletions

File tree

README.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,12 @@ The tracking issue for dynamic modules in general is [here](https://github.com/e
3030
## Development
3131

3232
```
33-
make test # Run all unit tests
34-
make build # Build all dynamic modules
35-
make integration-test # Run integration tests with Envoy
33+
# Run all unit tests
34+
make test
35+
# Build all dynamic modules
36+
make build
37+
# Run integration tests with Envoy
38+
make integration-test
3639
```
3740

3841
[Envoy]: https://github.com/envoyproxy/envoy

go/gosdk/abi.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,9 @@ func envoy_dynamic_module_on_http_filter_scheduled(
292292
filterModulePtr uintptr,
293293
eventID uint64,
294294
) {
295+
pinned := unwrapPinnedHttpFilter(uintptr(filterModulePtr))
296+
// Call the Scheduled method of the filter.
297+
pinned.obj.Scheduled(envoyFilter{raw: uintptr(filterEnvoyPtr)}, uint64(eventID))
295298
}
296299

297300
//export envoy_dynamic_module_on_http_filter_http_stream_reset

integration/main_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,8 @@ func TestIntegration(t *testing.T) {
8989
require.NoError(t, cmd.Start())
9090
t.Cleanup(func() {
9191
cancel()
92-
require.NoError(t, cmd.Process.Signal(os.Interrupt))
92+
time.Sleep(3 * time.Second)
93+
require.NoError(t, cmd.Process.Signal(os.Kill))
9394
})
9495
}
9596

0 commit comments

Comments
 (0)